Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add πŸ§ͺ emoji for TDD. Fixes (#284) #794

Merged
merged 7 commits into from
Jun 11, 2021

Conversation

devarops
Copy link
Contributor

Description

These changes are intended for the Test Driven Development cycle. The proposal is the following:

  1. πŸ§ͺ Add a failing test
  2. βœ… Make the test pass
  3. ♻️ Refactor the code

This PR updates the description of βœ… to "Make the tests pass" and adds πŸ§ͺ for "Add or update tests."

Discussion at #284

Tests

  • All tests passed.

@vercel
Copy link

vercel bot commented Jun 10, 2021

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

πŸ” Inspect: https://vercel.com/carloscuesta/gitmoji/7m6e5Qd8Ev4F7198zVxAZhWD56BQ
βœ… Preview: https://gitmoji-git-fork-evaristor-addtddemojis-carloscuesta.vercel.app

Copy link
Owner

@carloscuesta carloscuesta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for making the PR 😊

src/data/gitmojis.json Outdated Show resolved Hide resolved
src/data/gitmojis.json Outdated Show resolved Hide resolved
@devarops devarops marked this pull request as ready for review June 10, 2021 22:08
@devarops
Copy link
Contributor Author

Hi @carloscuesta! πŸ‘‹πŸΎ
I have addressed your comments. Would you be so kind as to review this PR again? πŸ™πŸΎ

@carloscuesta
Copy link
Owner

carloscuesta commented Jun 11, 2021

Sure! Sorry for the delay had a crazy and busy day today 😜

Copy link
Owner

@carloscuesta carloscuesta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's ship this 🚒

Thanks for the contribution and the time you took! 😊

@carloscuesta carloscuesta merged commit 6b84949 into carloscuesta:master Jun 11, 2021
@devarops
Copy link
Contributor Author

Thank you, @carloscuesta, for the chance to contribute to this project that I use every day! πŸ˜†

@devarops devarops deleted the add_tdd_emojis branch June 11, 2021 20:29
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 12, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants