Add emoji business logic Resolves #723 #829
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request is being automatically deployed with Vercel (learn more). 🔍 Inspect: https://vercel.com/carloscuesta/gitmoji/YDzFZUJ1VSAVFBYmnA3ayfZc7DLT |
carloscuesta
approved these changes
Aug 2, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
We have ✨ for additional features, but "features" for some projects imply only public behaviors. Adding utility functions, interfaces, wrappers, or any business/domain logic, for most public-facing libraries/projects would not be considered a "new feature". These additions live in the business/domain layer and are only for internal usage and will never be exposed via UI or API. Therefore, there is no good emoji in gitmoji to represent clearly that the addition or change is only meant for the business/domain layer.
👔 as suggested by #723 would resolve all these internal business logic commits and clarify that additions/changes are internal, not public, and live in the business/domain layer.
This may have some overlap with ♻️ (representing refactoring) as a change to business logic could sometimes be considered refactoring. However, I think ♻️ could consider being more specific and cover changes to the internal behavior of a module or function that do not affect inputs or outputs.
This may have some overlap with 🏗️ (representing architectural changes) as changes to the architecture could very well represent changes to business logic as well. However, I think 🏗️ would better represent major changes to the flow while 👔 would represent minor changes to input and output.
Ultimately, it would be up to the commiter to determine if the changes are big enough to be 🏗️, small enough to be ♻️, or fit perfectly with 👔. Any additions to the business/domain layer would almost always be 👔.
Tests