New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
♿️ Add focus trap to the menu #955
♿️ Add focus trap to the menu #955
Conversation
This pull request is being automatically deployed with Vercel (learn more). 🔍 Inspect: https://vercel.com/carloscuesta/gitmoji/6wbyxKHbqozhfzeC1Fq49A2NYW4D |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey! That's a great improvement thanks 😊
A small detail with the dependencies
@carloscuesta Outch really sorry 😓 seems that we can't use the I removed it and seems to work properly now. However the tabulation doesn't work in safari and firefox (but it is already the case in https://gitmoji.dev/). Will need to investigate waht this browsers need to handle tabulation. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! 😍
Description
Added a focus trap to the menu to that the user can't tab somewhere else in the hidden page. Use the react component base on focus-trap who seems trustworthy.
Tests