Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

📝 Improve ISSUE_TEMPLATE #963

Merged
merged 3 commits into from Jan 21, 2022
Merged

📝 Improve ISSUE_TEMPLATE #963

merged 3 commits into from Jan 21, 2022

Conversation

vhoyer
Copy link
Collaborator

@vhoyer vhoyer commented Jan 19, 2022

Description

Since it appear that people weren't too keen on answering the questions when it was in comment format, also this should save some time for maintainers and issue authors alike since we will hopefully skip the initial interactions.

Since it appear that people weren't too keen on answering the questions when it was in comment format, also this should save some time for maintainers and issue authors alike since we will hopefully skip the initial interactions.
@vercel
Copy link

vercel bot commented Jan 19, 2022

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/carloscuesta/gitmoji/3Hyw8vCVs8dEka2aeGZdkKso7pg1
✅ Preview: https://gitmoji-git-vhoyer-patch-1-carloscuesta.vercel.app

Copy link
Owner

@carloscuesta carloscuesta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice one! A tiny detail

but if you still think this one should be an inclusion, please spend some
extra time defending this aspect as well;
-->
## Create a defence for your emoji
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Defence wording seems a bit agressive to me can we change it to “Explain the use case of the emoji”?

@carloscuesta carloscuesta merged commit 556192d into master Jan 21, 2022
@carloscuesta carloscuesta deleted the vhoyer-patch-1 branch January 21, 2022 23:39
@carloscuesta
Copy link
Owner

Hey @vhoyer I changed the wording on the template as it felt a bit hard to me specially considering that sometimes is confusing contributing to Open Source.

Hope you don't mind ❤️

@carloscuesta carloscuesta changed the title 📝 Add a more in your face questions on issue template 📝 Improve ISSUE_TEMPLATE Jan 21, 2022
@vhoyer
Copy link
Collaborator Author

vhoyer commented Jan 21, 2022

No problem at all, thanks fir the review

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 23, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants