Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Do not override cursorShape #16

Closed
ricardocosta opened this issue Nov 2, 2017 · 2 comments
Closed

Do not override cursorShape #16

ricardocosta opened this issue Nov 2, 2017 · 2 comments
Labels
feature

Comments

@ricardocosta
Copy link

Hello @carloscuesta

First of all, great work with this theme!

I've been trying to customize the prompt to my taste with one of the oh-my-zsh themes and the only thing missing is the cursor shape. It seems that hyper-materialshell is overriding the .hyper.js configuration. https://github.com/carloscuesta/hyper-materialshell/blob/master/index.js#L20

Would you be willing to not do that? Since this theme is mostly changing colors, it seems weird to be forcing the users to UNDERLINE cursor instead of using the configuration.

Thanks!
@carloscuesta
Copy link
Owner

Hey @ricardocosta89!

I think it makes sense, so I'm removing it

@ricardocosta
Copy link
Author

Thanks!

@carloscuesta carloscuesta mentioned this issue Nov 4, 2017
Merged
carloscuesta added a commit that referenced this issue Nov 4, 2017
@carloscuesta
✨ Remove cursor shape (#17)
bbe682b 
* ✨ Remove cursorShape

* ✅ Match snapshots

* 🔖 Bump version to 1.6.1

Fixes #16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
feature
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@carloscuesta @ricardocosta