Skip to content

Commit

Permalink
chore: declare as required only the required inputs
Browse files Browse the repository at this point in the history
  • Loading branch information
carlosdevpereira committed Sep 26, 2022
1 parent da5cb8a commit d95a7ba
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 7 deletions.
2 changes: 0 additions & 2 deletions action.yml
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,6 @@ runs:
inputs:
framework:
description: "The test framework to run the unit tests of the repository. (Only 'jest' is available for now.)"
required: false
default: "jest"
githubToken:
description: "The github token that will be used to comment the results on available pull requests."
Expand All @@ -28,7 +27,6 @@ inputs:
required: true
baseCloudflareDeploymentUrl:
description: "The base URL configured on the target Cloudflare project from which the deployments will be served - It can also be a custom domain configured on the target project. (defaults to https://${cloudflareProjectName}.pages.dev)"
required: false

outputs:
coverage:
Expand Down
7 changes: 2 additions & 5 deletions index.js
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@ const COVERAGE_OUTPUT_FOLDER = "./coverage";
* the Github Action so that we can later use them
**/
const input = {
framework: core.getInput("framework", { required: false }),
framework: core.getInput("framework"),
githubToken: core.getInput("githubToken", { required: true }),
cloudflareProjectName: core.getInput("cloudflareProjectName", {
required: true,
Expand All @@ -24,10 +24,7 @@ const COVERAGE_OUTPUT_FOLDER = "./coverage";
cloudflareAccountId: core.getInput("cloudflareAccountId", {
required: true,
}),
baseCloudflareDeploymentUrl: core.getInput(
"baseCloudflareDeploymentUrl",
{ required: false }
),
baseCloudflareDeploymentUrl: core.getInput("baseCloudflareDeploymentUrl"),
};

/**
Expand Down

0 comments on commit d95a7ba

Please sign in to comment.