Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: Get branchName from context instead of an input variable #14

Closed
carlosdevpereira opened this issue Oct 16, 2022 · 0 comments · Fixed by #19
Closed

chore: Get branchName from context instead of an input variable #14

carlosdevpereira opened this issue Oct 16, 2022 · 0 comments · Fixed by #19
Assignees
@carlosdevpereira

Comments

@carlosdevpereira
Copy link
Owner

carlosdevpereira commented Oct 16, 2022 •
edited
Loading

  • BREAKING CHANGE

Description

Currently this action relies on the user passing a branchName input parameter, identifying the branch that triggered the workflow run.

This was done like this because of an issue that prevented us from getting this value from the github context and might not be happening anymore.

Proposed solution

Replace the branchName parameter with the value provided by github context again.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@carlosdevpereira carlosdevpereira

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

chore: get branch that triggered workflow from context carlosdevpereira/test-publish-to-cloudflare
1 participant
@carlosdevpereira