Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: clean up the commit comment body #17

Closed
carlosdevpereira opened this issue Oct 19, 2022 · 0 comments · Fixed by #22
Closed

chore: clean up the commit comment body #17

carlosdevpereira opened this issue Oct 19, 2022 · 0 comments · Fixed by #22
Assignees
@carlosdevpereira
Labels
Improvement

Comments

@carlosdevpereira
Copy link
Owner

Description

Currently this action is commenting a huge json string on the commits and most of the properties of that JSON comment are not being used.

Proposed solution:

Comment only the properties needed for the action to work
@carlosdevpereira carlosdevpereira self-assigned this Oct 19, 2022
@carlosdevpereira carlosdevpereira mentioned this issue Oct 24, 2022
Merged
carlosdevpereira added a commit that referenced this issue Oct 24, 2022
@carlosdevpereira
feat: generate coverage badges and clean commit comments (#22)
3b0173c 
## Issue

Fixes: #16 
Fixes: #17

## Description

Generates coverage and test badges and comments only the necessary
fields on commits
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@carlosdevpereira carlosdevpereira

Labels
Improvement
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: generate coverage badges and clean commit comments carlosdevpereira/test-publish-to-cloudflare
1 participant
@carlosdevpereira