Make every icon a static; Create separation of concern between component libs and icon sources. #33
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes:
&'static IconData
&IconData
as inputIconData
now implementsSerialize
andDeserialize
behind a feature flagicondata
, they should only depend onicondata_core
.This last point makes it so that component libraries don't have to constantly change version when the icon source changes version. Downstream users of the component library should bring their icon source.