Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to Leptos 0.6 #41

Merged
merged 4 commits into from
Jan 29, 2024
Merged

Update to Leptos 0.6 #41

merged 4 commits into from
Jan 29, 2024

Conversation

paul-hansen
Copy link
Contributor

Just a simple version bump. Example was working for me and was able to use it in my project using these changes.

@paul-hansen
Copy link
Contributor Author

paul-hansen commented Jan 29, 2024

@Carlosted Looks like you have a test that runs against minimal versions of the library (which is cool, didn't know you could do that) It was failing on the bytes crate being too old and not implementing a trait that was used in leptos' server_fn crate. I added the minimal version of bytes that compiles to the [target.'cfg(any())'.dependencies] section of the Cargo.toml as that looks like how you have fixed other cases of this.
I was able to replicate the failure locally using the steps from the github workflow and this seems to fix it. I'm not very familiar with how this works though so feel free to correct me or make changes to this branch as needed. Thanks!

@paul-hansen
Copy link
Contributor Author

Other CI failures should all be addressed now too 🤞

Since Leptos doesn't state an msrv in their Cargo.toml, I just checked each Rust version until I found the next that worked and used that.

@carloskiki
Copy link
Owner

This is great TY!

I will merge and publish a new version of leptos-icons for leptos v0.6.

@carloskiki carloskiki merged commit 3abc8af into carloskiki:main Jan 29, 2024
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants