[FEATURE]: Publish monthly a plot on Twitter with the gas price variation #9 #11

Dntfreitas · 2022-08-17T22:52:26Z

What this PR does

Publishes, every month, a plot with the gas variation from the last 6 months.

joaoofreitas

This is great.

I have fewer sugestions of things we can do to further improve it, either now or in future development.

Do we really need to save the plots as a picture in out git repository, or can we just have an image object that we can upload to Twitter straight in the github action?
Would be interesting in a futuredevelopment to add some styling to the plot with the python PIL library.

Very good and solid code. Approved.
Good job! @Dntfreitas

constants.py

history/generate_plot.py

carlosrsabreu

Amazing work! Well done, @Dntfreitas ! 🎉

Just left a note according to the comment of @joaoofreitas.

constants.py

history/generate_plot.py

A constant was included for completeness

Dntfreitas · 2022-09-10T16:40:39Z

Hey All,

If you agree, I can merge this PR.

Thanks for the feedback ;)

carlosrsabreu

Just leave a note on a constant, not critical. Just take a look at it, and it's ready to merge!

constants.py

carlosrsabreu · 2023-01-10T23:08:21Z

@Dntfreitas let us know if we can merge this PR. If yes, you can do it directly. Let's clean the completed issues and PRs.

Dntfreitas · 2023-01-11T10:11:16Z

Guys, please check if everything is okay.

joaoofreitas

Looks good. Ready to merge IMO.

carlosrsabreu

Nice work, @Dntfreitas ! 🙌

HarryVasanth

Overall good changes, except for one typo from the mainbranch itself and the need to remove git add history/img/plot.png from main.yml.

HarryVasanth · 2023-01-11T23:25:02Z

script.py

@@ -49,8 +49,7 @@
 # If we don't have the date, update
 if update:
    # Prepare the dictionaire
-    dict_prices = {PREVIOUS_WEEK: curret_data[CURRENT_WEEK]}
-    dict_prices[CURRENT_WEEK] = {START_DATE_KEY: start_date, END_DATE_KEY: end_date, GAS_KEY: {}}
+    dict_prices = {PREVIOUS_WEEK: curret_data[CURRENT_WEEK], CURRENT_WEEK: {START_DATE_KEY: start_date, END_DATE_KEY: end_date, GAS_KEY: {}}}


There is typo curret_data, should be current_data; this stems from here:

devo-abastecer/script.py

Lines 13 to 15 in 010431a

curret_data = json.load(f)

current_start_date_saved = curret_data[CURRENT_WEEK][START_DATE_KEY]

current_end_date_saved = curret_data[CURRENT_WEEK][END_DATE_KEY]

HarryVasanth · 2023-01-11T23:26:09Z

.github/workflows/main.yml

@@ -33,5 +33,6 @@ jobs:
          git add gas_info.json
          git add history/gas_info_history.csv
          git add history/gas_info_history.json
+          git add history/img/plot.png


This line should be removed since you are not writing the file on the repo any more.

HarryVasanth · 2023-01-11T23:29:42Z

Nice work, @Dntfreitas ! 🙌

@carlosrsabreu : Sorry, didn't realize this was merged while I went to have my dinner 🙁

carlosrsabreu · 2023-01-12T19:24:56Z

Nice work, @Dntfreitas ! 🙌

@carlosrsabreu : Sorry, didn't realize this was merged while I went to have my dinner 🙁

Sorry, @HarryVasanth ! I though you saw before merged it 😔 You were checked in the reviewers' section

Dntfreitas added 7 commits August 17, 2022 21:53

Initial solution

97851ed

Update README

1689c71

Integration with main script

97ee826

Implementatiton of GH Action

8806e41

GH Action on the first day of the month

f0fef25

Change name of the GH Action

12720e1

Considers only data from the last 6 months

0c6ee35

Dntfreitas added the 🪄 enhancement New feature or enhancement label Aug 17, 2022

Dntfreitas requested review from carlosrsabreu and joaoofreitas August 17, 2022 22:52

Dntfreitas linked an issue Aug 17, 2022 that may be closed by this pull request

[FEATURE]: Publish monthly a plot on Twitter with the gas price variation #9

Closed

joaoofreitas approved these changes Aug 18, 2022

View reviewed changes

constants.py Outdated Show resolved Hide resolved

history/generate_plot.py Outdated Show resolved Hide resolved

Dntfreitas and others added 3 commits August 18, 2022 19:17

Update constants.py

1f4854a

Fix issue

b6e69ae

chore: typo on var

3267fe8

carlosrsabreu previously requested changes Aug 22, 2022

View reviewed changes

constants.py Outdated Show resolved Hide resolved

history/generate_plot.py Outdated Show resolved Hide resolved

13dev reviewed Aug 31, 2022

View reviewed changes

history/generate_plot.py Outdated Show resolved Hide resolved

Dntfreitas requested a review from carlosrsabreu September 10, 2022 16:33

Dntfreitas added 2 commits September 10, 2022 17:34

Remove nonessential comments

8d9bacc

Merge branch 'main' into feat/plot

dd6abab

Dntfreitas requested review from 13dev and joaoofreitas and removed request for 13dev September 10, 2022 16:39

13dev approved these changes Sep 12, 2022

View reviewed changes

carlosrsabreu approved these changes Sep 12, 2022

View reviewed changes

constants.py Outdated Show resolved Hide resolved

Update constants.py

9899a3e

joaoofreitas approved these changes Sep 16, 2022

View reviewed changes

Now it generates the plot just before tweeting

d571b58

Dntfreitas requested review from joaoofreitas, carlosrsabreu, HarryVasanth and 13dev and removed request for HarryVasanth and 13dev January 11, 2023 10:08

Dntfreitas requested review from HarryVasanth and removed request for 13dev January 11, 2023 10:11

joaoofreitas approved these changes Jan 11, 2023

View reviewed changes

Dntfreitas requested review from 13dev and removed request for HarryVasanth and 13dev January 11, 2023 18:03

carlosrsabreu approved these changes Jan 11, 2023

View reviewed changes

carlosrsabreu merged commit 010431a into main Jan 11, 2023

carlosrsabreu deleted the feat/plot branch January 11, 2023 22:43

HarryVasanth reviewed Jan 11, 2023

View reviewed changes

HarryVasanth changed the title ~~wrt issue #9~~ [FEATURE]: Publish monthly a plot on Twitter with the gas price variation #9 Jan 24, 2023

HarryVasanth assigned Dntfreitas Jan 24, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[FEATURE]: Publish monthly a plot on Twitter with the gas price variation #9 #11

[FEATURE]: Publish monthly a plot on Twitter with the gas price variation #9 #11

Dntfreitas commented Aug 17, 2022 •

edited

joaoofreitas left a comment

carlosrsabreu left a comment

Dntfreitas commented Sep 10, 2022

carlosrsabreu left a comment

carlosrsabreu commented Jan 10, 2023

Dntfreitas commented Jan 11, 2023

joaoofreitas left a comment

carlosrsabreu left a comment

HarryVasanth left a comment

HarryVasanth Jan 11, 2023

HarryVasanth Jan 11, 2023

HarryVasanth commented Jan 11, 2023

carlosrsabreu commented Jan 12, 2023

	curret_data = json.load(f)
	current_start_date_saved = curret_data[CURRENT_WEEK][START_DATE_KEY]
	current_end_date_saved = curret_data[CURRENT_WEEK][END_DATE_KEY]

[FEATURE]: Publish monthly a plot on Twitter with the gas price variation #9 #11

[FEATURE]: Publish monthly a plot on Twitter with the gas price variation #9 #11

Conversation

Dntfreitas commented Aug 17, 2022 • edited

What this PR does

joaoofreitas left a comment

Choose a reason for hiding this comment

carlosrsabreu left a comment

Choose a reason for hiding this comment

Dntfreitas commented Sep 10, 2022

carlosrsabreu left a comment

Choose a reason for hiding this comment

carlosrsabreu commented Jan 10, 2023

Dntfreitas commented Jan 11, 2023

joaoofreitas left a comment

Choose a reason for hiding this comment

carlosrsabreu left a comment

Choose a reason for hiding this comment

HarryVasanth left a comment

Choose a reason for hiding this comment

HarryVasanth Jan 11, 2023

Choose a reason for hiding this comment

HarryVasanth Jan 11, 2023

Choose a reason for hiding this comment

HarryVasanth commented Jan 11, 2023

carlosrsabreu commented Jan 12, 2023

Dntfreitas commented Aug 17, 2022 •

edited