Merge Jogge/xUnit-TeamCity #20
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… existing handling prevented users from ignoring failed unit tests
…cess.java - Concurrent execution of xUnit test assemblies
Conflicts: xunit-agent/src/main/java/se/capeit/dev/xunittestrunner/XUnitBuildProcess.java
…cess.java (BuildFinishedStatus): - Fixed compilation error introduced in merge conflict. The log context is now kept in a dictionary.
|
Since this hasn't received any feedback, I will merge this. |
|
@carlpett will there be a new release now that the PR is merged? I'd like to update a teamcity instance to support xUnit 2.2 and would prefer to avoid compiling it myself. :) |
|
@brunomlopes Yes. I had hoped to do a release the past weekend, but didn't manage to finish the things I would like to get into a 1.2. I could build a pre-release with the current master though, if that'd be helpful? |
|
@carlpett that would be very helpful, yes :) thanks. |
|
@brunomlopes Sorry it took a while, but I've posted a pre-release now. Please let me know how it goes! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Despite adding several very nice features, #18 has been hanging around for soon 5 months without a merge (and even winning the "People's choice award" in the Teamcity Plugin Contest!).
Since xUnit 2.2 was released recently, one of the major hold-backs for merging is resolved. I've updated the PR with the full release, as well as fixing some of the other aspects I initially waited for.
@Jogge, @robert-j-engdahl - Any comments on the additions?