Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DateRangeFilter tests #32

Closed
dmishe opened this issue Jan 31, 2010 · 3 comments
Closed

DateRangeFilter tests #32

dmishe opened this issue Jan 31, 2010 · 3 comments

Comments

@dmishe
Copy link

dmishe commented Jan 31, 2010

Hardcoding 2009 year and using today() in tests is not a good idea.
@tomchristie
Copy link
Contributor

Suggest this issue is closed, unless anyone wants to actually submit a pull req.

@apollo13
Copy link
Contributor

We should at least fix https://github.com/alex/django-filter/blob/master/django_filters/tests/tests.py#L454

@nkryptic nkryptic mentioned this issue Feb 2, 2013
Closed
dfejgelis pushed a commit to dfejgelis/django-filter that referenced this issue Mar 18, 2014
@crucialfelix
fix: move staticfiles into static/ajax_select to work correctly with …
e5722d9 
…staticfiles Fixes carltongibson#6 Fixes carltongibson#32
@carltongibson
Copy link
Owner

I'm going to close this. Searching for "2009" returns no results, so I'll assume that somewhere along the line it got fixed.

Happy to receive PRs on specific improvements to the tests.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@carltongibson @apollo13 @dmishe @tomchristie