Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FilterView strict #1052

Closed
wants to merge 3 commits into from
Closed

Conversation

k0t3n
Copy link

@k0t3n k0t3n commented Mar 6, 2019

  • Add strict references to docs when using FilterView

Unfortunately, after #788 there is no mention of this feature in the documentation.

@k0t3n
Copy link
Author

k0t3n commented Mar 9, 2019

@carltongibson what do you think about this?

@carltongibson
Copy link
Owner

More or less, first pass was “this is in the wrong place”. We need a FilterView ref doc.

Haven’t had time to think it through more than that yet. (Hence no response thus far.)

Please drop the ignore changes.

@codecov-io
Copy link

codecov-io commented Mar 9, 2019

Codecov Report

Merging #1052 into master will increase coverage by <.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1052      +/-   ##
==========================================
+ Coverage   98.34%   98.34%   +<.01%     
==========================================
  Files          15       15              
  Lines        1205     1208       +3     
==========================================
+ Hits         1185     1188       +3     
  Misses         20       20
Impacted Files Coverage Δ
django_filters/filters.py 99.7% <0%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ab31272...04815a0. Read the comment docs.

@k0t3n
Copy link
Author

k0t3n commented Mar 9, 2019

@carltongibson ok, let me know if I can help with it.

@carltongibson
Copy link
Owner

Hi @k0t3n. Sorry for the slow reply. Looking again I just don't think this clarifies anything placed where it is.

Happy to discuss docs improvements here but I don't think this one is it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants