Fully exclude tests modules in setup.py #602
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
👍 although it needs to be rebased. It probably wouldn't hurt to also remove the following from |
|
Well, personally I'd prefer the tests to be in the release tarball, as it allows us to run the tests downstream in the Fedora package build. It's just when actually installing that they should be excluded. |
Just excluding 'tests' doesn't seem to be enough: it results in tests/rest_framework being installed systemwide when you run `python setup.py install`. Excluding 'tests*' seems to do the trick.
AdamWill
force-pushed
the
tests-exclude
branch
from
756c40e
to
101cd2f
Compare
|
OK. We'll stick. Thanks for there input @AdamWill! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Just excluding 'tests' doesn't seem to be enough: it results in
tests/rest_framework being installed systemwide when you run
python setup.py install. Excluding 'tests*' seems to do thetrick.