Add filter_fields to FilterView #632
Conversation
If you have a FilterView only providng a model it could be useful to specify the fields you want to include or exclude to filterset automatic construction.
Hi @marctc. This seems a reasonable addition. I'm kind of of the opinion that ever adding |
I added because sometimes could be useful to exclude some fields and also to emulate the behaviour of Should I remove then? |
Yeah. I think so. Also, it should probably be Did you need this yourself? (The minimal |
I named it
What do you mean? |
I mean, what prompted you to suggest this? I see the point of it but, also it's not hard to define I'm wondering if it's something you actually wanted in real usage? |
We are building an ERP for a client and there a lot of models and a lot of FilterViews. Those views automatically renders the filter with all of the fields. If I want to exclude or explicity set a subset of fields, I have to define a filterset for each view. I'm a lazy developer, sorry :P |
That's not a problem. :-) OK. It's reasonable. If you can make the changes we can have it. (I'm going to roll 1.0.2 this week, so it can join that.) |
Thanks! Working on it. |
Done |
Awesome. Thanks. |
c168e9d
into
carltongibson:develop
If you have a FilterView only providng a model it could be useful to specify the fields you want to include to the filterset automatic construction.