Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update names.csv #65

Merged
merged 2 commits into from Jan 17, 2024
Merged

Update names.csv #65

merged 2 commits into from Jan 17, 2024

Conversation

ericbn
Copy link
Contributor

@ericbn ericbn commented Jan 16, 2024

using data from https://web.archive.org/web/20181022154748/https://deron.meranda.us/data/nicknames.txt

I assumed chrintina, cinderlla and vincenzon (sic) are typos for chriStina, cinderElla and vincenzo, although chrintina seems to be a valid uncommon name.

using data from
https://web.archive.org/web/20181022154748/https://deron.meranda.us/data/nicknames.txt

I assumed chrintina, cinderlla and vincenzon (sic) are typos for
chriStina, cinderElla and vincenzo, although chrintina seems to be a
valid uncommon name.
@ericbn
Copy link
Contributor Author

ericbn commented Jan 16, 2024

Regarding the CI failure:

git diff-index --quiet HEAD || (echo "Committing changes" && git commit -am 'chore: normalize data and re-sync' && echo "Pushing changes" && git push -f)

is outputing:

Committing changes
HEAD detached at pull/65/merge
nothing to commit, working tree clean

Weird that git diff-index --quiet HEAD returns a non-zero status and then apparently git commit outputs "nothing to commit, working tree clean"...

I've ran both python normalize.py and python sql/generate_sql.py already.

@NickCrews NickCrews merged commit d3b9075 into carltonnorthern:master Jan 17, 2024
16 of 17 checks passed
@NickCrews
Copy link
Collaborator

yeah that CI script isn't quite right, I need to fix it. This looks great, really appreciate the effort and your changes @ericbn !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants