Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update CHANGELOG #248

Merged
merged 2 commits into from Dec 6, 2017
Merged

Update CHANGELOG #248

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
5169614
Update CHANGELOG to reflect changes from #247
swcraig Nov 30, 2017
8bd6939
Add PR template
swcraig Nov 30, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
11 changes: 11 additions & 0 deletions .github/PULL_REQUEST_TEMPLATE.md
View file
Open in desktop
@@ -0,0 +1,11 @@
For non-trivial PRs, please add an entry to the CHANGELOG (following the convention in place).

If the changes are geography related (overlay/locale modifications) place the entry under "Geographic Modifications".

Please follow this format _exactly_:

`[#<pr-number>] <PR description _without_ an ending period> ([@<github-handle>](<github-profile>))`

------------------------------------------

**Please remove the text in this template before submitting your Pull Request**
4 changes: 4 additions & 0 deletions CHANGELOG.md
View file
Open in desktop
@@ -1,5 +1,9 @@
### master (unreleased)

##### Geographic Modifications
* [#247](https://github.com/carmen-ruby/carmen/pull/247) Fix New Zealand regions
to match 2015-11-27 ISO correction ([@louim](https://github.com/louim))

### 1.1.0 (November 7, 2017)
* [#231](https://github.com/carmen-ruby/carmen/pull/231) Base ISO data has been updated for the first time since October 25, 2014
* [#233](https://github.com/carmen-ruby/carmen/pull/233) Revert removing Puerto Rico as a country code
Expand Down