Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't send 'Tab' when 'autotype' and 'username' is undefined #37

Closed
stonewareslord opened this issue May 19, 2016 · 0 comments
Closed

Comments

@stonewareslord
Copy link

Here: https://github.com/carnager/rofi-pass/blob/master/rofi-pass#L45, it looks like tab will always be sent if a password has no autotype field, but I think that rofi should detect if a username field exists, and only send a tab if it does.

Here's a use case that works as expected from the current implementation. router-password:

password

---
user: username

rofi-pass would send username\tpassword through xdotool, but if router-password contains:

password

---

rofi-pass would just send \tpassword, which would almost always tab out of the highlighted password field. I believe a good solution is detecting if USERNAME_field is defined, if so, send ${USERNAME_field}\t${password}, if not, just send ${password}

Nobutarou pushed a commit to Nobutarou/rofi-pass that referenced this issue Dec 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant