Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ntfy:// markdown support added #1056

Merged
merged 1 commit into from Feb 3, 2024
Merged

ntfy:// markdown support added #1056

merged 1 commit into from Feb 3, 2024

Conversation

caronc
Copy link
Owner

@caronc caronc commented Feb 3, 2024

Description:

Related issue (if applicable): #1053

Simply add support for ?format=markdown that can be applied to the Apprise ntfy:// URL. Default is still to pass as is (text) to avoid breaking existing system setup.

Checklist

  • The code change is tested and works locally.
  • There is no commented out code in this PR.
  • No lint errors (use flake8)
  • 100% test coverage

Testing

Anyone can help test this source code as follows:

# Create a virtual environment to work in as follows:
python3 -m venv apprise

# Change into our new directory
cd apprise

# Activate our virtual environment
source bin/activate

# Install the branch
pip install git+https://github.com/caronc/apprise.git@1053-ntfy-markdown-support

# Test out the changes with the following command:
apprise -t "Test Title" -b "Test Message" \
  "ntfy://mytopic/?format=markdown"

@codecov-commenter
Copy link

codecov-commenter commented Feb 3, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (31a4f2e) 99.27% compared to head (382dce5) 99.27%.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #1056   +/-   ##
=======================================
  Coverage   99.27%   99.27%           
=======================================
  Files         135      135           
  Lines       17600    17603    +3     
  Branches     3592     3593    +1     
=======================================
+ Hits        17472    17475    +3     
  Misses        119      119           
  Partials        9        9           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@caronc caronc merged commit e9beea2 into master Feb 3, 2024
12 checks passed
@caronc caronc deleted the 1053-ntfy-markdown-support branch February 3, 2024 19:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants