Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Windows notifications: Correct WM_DESTROY return value #863

Merged
merged 1 commit into from
Apr 20, 2023

Conversation

NHellFire
Copy link
Contributor

Description:

Fixes this error with Windows notifications:

>apprise -v -b Test windows://
WNDPROC return value cannot be converted to LRESULT
TypeError: WPARAM is simple, so must be an int object (got NoneType)

The WM_DESTROY handler should return 0:
https://learn.microsoft.com/en-us/windows/win32/winmsg/wm-destroy#return-value

Checklist

  • The code change is tested and works locally.
  • There is no commented out code in this PR.
  • No lint errors (use flake8)
  • 100% test coverage

Signed-off-by: Nathan Rennie-Waldock <nathan.renniewaldock@gmail.com>
@caronc
Copy link
Owner

caronc commented Apr 20, 2023

I haven't seen the side effects of the None return, but i appreciate the PR. Will merge for consistency with Microsoft docs. Can you confirm it's still working for you after this minor change?

@NHellFire
Copy link
Contributor Author

NHellFire commented Apr 20, 2023 via email

@caronc caronc merged commit 9b4d345 into caronc:master Apr 20, 2023
10 of 15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants