Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added Attachment Support for Apprise API #873

Merged
merged 2 commits into from
May 12, 2023
Merged

Conversation

caronc
Copy link
Owner

@caronc caronc commented May 8, 2023

Description:

Related issue (if applicable): n/a

This is the first part of being able to send attachments to the Apprise API Server with respect to this ticket

This PR allows the attachments to be passed along upstream to the Apprise API server.

An add on needs to be created to the Apprise API to temporarily story the attachments to disk so that it can re-transmit them.

Checklist

  • The code change is tested and works locally.
  • There is no commented out code in this PR.
  • No lint errors (use flake8)
  • 100% test coverage

Testing

Anyone can help test this source code as follows:

# Create a virtual environment to work in as follows:
python3 -m venv apprise

# Change into our new directory
cd apprise

# Activate our virtual environment
source bin/activate

# Install the branch
pip install git+https://github.com/caronc/apprise.git@apprise-api-attachments

# Test out the changes with the following command:
apprise -t "Test Title" -b "Test Message" "apprise://your-apprise-api-host/"

@caronc caronc merged commit b327abf into master May 12, 2023
15 of 16 checks passed
@caronc caronc deleted the apprise-api-attachments branch May 13, 2023 02:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant