Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Configurable Parameters #23

Merged
merged 1 commit into from
Jan 9, 2018
Merged

Configurable Parameters #23

merged 1 commit into from
Jan 9, 2018

Conversation

bcylin
Copy link
Collaborator

@bcylin bcylin commented Jan 7, 2018

Add a struct for the parameters that ImagePickerConfigurable requires. It should make the customisation easier without creating an additional type.

var parameters = Pickle.Parameters()
parameters.allowedSelections = .limit(to: 4)
let picker = ImagePickerController(configuration: parameters)

@carouselljenkins
Copy link

@rance-attack, can you review this pull request?

@carouselljenkins
Copy link

1 Warning
⚠️ Big PR

Generated by 🚫 Danger

@bcylin bcylin merged commit 8cb1b9e into master Jan 9, 2018
@bcylin bcylin deleted the feature/parameters branch January 9, 2018 15:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rance-attack rance-attack rance-attack approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@bcylin @carouselljenkins @rance-attack