Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Xcode 10 #26

Merged
merged 8 commits into from
Oct 2, 2018
Merged

Xcode 10 #26

merged 8 commits into from
Oct 2, 2018

Conversation

bcylin
Copy link
Collaborator

@bcylin bcylin commented Sep 30, 2018

Update the project to Xcode 10

  • Update to CocoaPods (1.5.3)
  • Specify swift_version = 4.0 in the podspec
  • Fix warnings and test cases

@carouselljenkins
Copy link

@rance-attack, can you review this pull request?

@carouselljenkins
Copy link

carouselljenkins commented Sep 30, 2018

✅ Yay.
Please update CHANGELOG.md.
1 Warning
⚠️ Big PR
Pickle/Classes/ImagePickerController.swift#L229 - Pickle/Classes/ImagePickerController.swift#L229 has linter issue: Initializing an optional variable with nil is redundant..
Pickle/Classes/ImagePickerController.swift#L299 - Pickle/Classes/ImagePickerController.swift#L299 has linter issue: Fallthroughs can only be used if the case contains at least one other statement..

Generated by 🚫 Danger

@tflhyl
Copy link
Contributor

tflhyl commented Oct 1, 2018

lol @bcylin dont realize u also fixing..

@bcylin
Copy link
Collaborator Author

bcylin commented Oct 1, 2018

Oh I forgot there’s Hacktoberfest. I seem to be a day early. 😅

@bcylin bcylin merged commit 7972c1e into master Oct 2, 2018
@bcylin bcylin deleted the feature/xcode-10 branch October 2, 2018 23:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants