Support video in the picker #44
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,6 @@ | ||
| { | ||
| "info" : { | ||
| "version" : 1, | ||
| "author" : "xcode" | ||
| } | ||
| } |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,12 @@ | ||
| { | ||
| "images" : [ | ||
| { | ||
| "idiom" : "universal", | ||
| "filename" : "video-icon.pdf" | ||
| } | ||
| ], | ||
| "info" : { | ||
| "version" : 1, | ||
| "author" : "xcode" | ||
| } | ||
| } |
Binary file not shown.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change | ||||
|---|---|---|---|---|---|---|
| @@ -0,0 +1,73 @@ | ||||||
| // | ||||||
| // This source file is part of the carousell/pickle open source project | ||||||
| // | ||||||
| // Copyright © 2017 Carousell and the project authors | ||||||
| // Licensed under Apache License v2.0 | ||||||
| // | ||||||
| // See https://github.com/carousell/pickle/blob/master/LICENSE for license information | ||||||
| // See https://github.com/carousell/pickle/graphs/contributors for the list of project authors | ||||||
| // | ||||||
|
|
||||||
| internal final class VideoPropertyView: UIView { | ||||||
|
There was a problem hiding this comment. It's generally a good practice to specify explicit access control levels in a library. It implies that a method should only be made public in the future with careful consideration. The |
||||||
|
|
||||||
| private let videoIcon: UIImageView = { | ||||||
| let icon = UIImageView() | ||||||
| icon.tintColor = .white | ||||||
| icon.image = UIImage(named: "video-icon")?.withRenderingMode(.alwaysTemplate) | ||||||
|
There was a problem hiding this comment. You might need to specify the framework bundle that contains the image. init?(named name: String, in bundle: Bundle?, compatibleWith traitCollection: UITraitCollection?) |
||||||
| return icon | ||||||
| }() | ||||||
|
|
||||||
| private let durationLabel: UILabel = { | ||||||
| let label = UILabel() | ||||||
| label.font = UIFont.boldSystemFont(ofSize: 12) | ||||||
| label.textAlignment = .right | ||||||
| label.textColor = .white | ||||||
| return label | ||||||
| }() | ||||||
|
|
||||||
| func configure(duration: TimeInterval) { | ||||||
| let formatter = DateComponentsFormatter() | ||||||
| formatter.zeroFormattingBehavior = .pad | ||||||
|
|
||||||
| if duration >= 3600 { | ||||||
| formatter.allowedUnits = [.hour, .minute, .second] | ||||||
| } else { | ||||||
| formatter.allowedUnits = [.minute, .second] | ||||||
| } | ||||||
|
|
||||||
| durationLabel.text = formatter.string(from: duration) | ||||||
| } | ||||||
|
|
||||||
| func setSelected(_ value: Bool) { | ||||||
| if value { | ||||||
|
There was a problem hiding this comment.
Suggested change
|
||||||
| backgroundColor = UIColor.Palette.blue | ||||||
| } else { | ||||||
| backgroundColor = UIColor.Palette.darkGray.withAlphaComponent(0.2) | ||||||
| } | ||||||
| } | ||||||
|
|
||||||
| override init(frame: CGRect) { | ||||||
| super.init(frame: frame) | ||||||
| setupViews() | ||||||
| } | ||||||
|
|
||||||
| required init?(coder aDecoder: NSCoder) { | ||||||
| fatalError("init(coder:) has not been implemented") | ||||||
| } | ||||||
|
|
||||||
| private func setupViews() { | ||||||
| backgroundColor = UIColor.Palette.darkGray.withAlphaComponent(0.2) | ||||||
|
|
||||||
| addSubview(videoIcon) | ||||||
| videoIcon.translatesAutoresizingMaskIntoConstraints = false | ||||||
| videoIcon.heightAnchor.constraint(equalToConstant: 16).isActive = true | ||||||
| videoIcon.widthAnchor.constraint(equalToConstant: 16).isActive = true | ||||||
| videoIcon.leadingAnchor.constraint(equalTo: leadingAnchor, constant: 4).isActive = true | ||||||
| videoIcon.centerYAnchor.constraint(equalTo: centerYAnchor).isActive = true | ||||||
|
|
||||||
| addSubview(durationLabel) | ||||||
| durationLabel.translatesAutoresizingMaskIntoConstraints = false | ||||||
| durationLabel.trailingAnchor.constraint(equalTo: trailingAnchor, constant: -4).isActive = true | ||||||
| durationLabel.centerYAnchor.constraint(equalTo: centerYAnchor).isActive = true | ||||||
| } | ||||||
| } | ||||||
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should be
all?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
PHAsset has audio mediaType as well.
https://developer.apple.com/documentation/photokit/phassetmediatype
any better suggestion? or do u think can use
all?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
.unknowndoesn't make sense I feel. How about removing.unknownand bitmasking it usingOptionSet?https://developer.apple.com/documentation/swift/optionset
Then the API consumer can pass in any combination of mediaType they desire:
mediaType: ImagePickerMediaType = [.video, .image]mediaType: ImagePickerMediaType = [.video, .audio]mediaType: ImagePickerMediaType = .videomediaType: ImagePickerMediaType = .all...