FIX: Fix slice orientations

[kaitj]

Resolves #118 - flipping the rotations in the yaw & roll in the sagittal view seems to have resolved this. Views should now be "Sagittal right" and "Coronal anterior" The rotations applied here was used to produce the figure in #120.

[netlify]

Deploy preview for carpentries-dmri ready!

Built with commit e78b80e

https://deploy-preview-121--carpentries-dmri.netlify.app

[jhlegarreta]

Checked locally. A few comments:

• Are we sure that the coronal anterior is a coronal anterior? Looking at it I'd say that it's a coronal posterior; looking at the sagittal, things get a little bit more confusing.
• Fixing the coronal by setting the sagittal means that the fix would work if we call the methods in a given order. We should reset the camera in each method and then perform the appropriate changes to it so that it does not depend on the changes that were applied previously.

I think all concerned figures should be updated within this PR.

Also, I've realized about a mistake of mine in PR #92 and have submitted PR #122, so prior to generating all figures, this branch should be rebased on master once the latter PR gets merged. My bad. Sorry @kaitj .

[kaitj]

* Are we sure that the coronal anterior is a coronal anterior? Looking at it I'd say that it's a coronal posterior; looking at the sagittal, things get a little bit more confusing.

Ahh yeah, took another look, you are right. 29e2e6b should fix this to coronal anterior (pitch changed to -90)

* Fixing the coronal by setting the sagittal means that the fix would work if we call the methods in a given order. We should reset the camera in each method and then perform the appropriate changes to it so that it does not depend on the changes that were applied previously.

Yeah, I noticed that that too. I think for now, for the purposes of generating the figures in the correct orientations, this is probably temporarily fine, but definitely want to look into resetting the camera as a more permanent solution.

Also, I've realized about a mistake of mine in PR #92 and have submitted PR #122, so prior to generating all figures, this branch should be rebased on master once the latter PR gets merged. My bad. Sorry @kaitj .

No worries!

[jhlegarreta]

I've merged #122. We can rebase this on master and hopefully get all figures generated correctly within this PR.

[jhlegarreta]

Figures will need to be updated in a separate PR then.

[kaitj]

Yes, I created a new issue to keep track of this. Merged this in as I had already rebased my local master and it would have gotten merged in with #130 otherwise.