Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FIX: Reset notebook kernel #137

Merged
merged 3 commits into from
Apr 14, 2021

Conversation

kaitj
Copy link
Collaborator

@kaitj kaitj commented Apr 14, 2021

Deterministic tractography solutions notebook was causing workflow to fail due to use of a local kernel. Reset it with this PR.

@kaitj kaitj added the type:bug Code included in the lesson needs to be fixed label Apr 14, 2021
@kaitj kaitj self-assigned this Apr 14, 2021
@netlify
Copy link

netlify bot commented Apr 14, 2021

Deploy preview for carpentries-dmri ready!

Built with commit c6eb00d

https://deploy-preview-137--carpentries-dmri.netlify.app

Copy link
Contributor

@jhlegarreta jhlegarreta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Have not tested.

@josephmje
Copy link
Contributor

@kaitj could you try also getting rid of

  "language_info": {
   "codemirror_mode": {
    "name": "ipython",
    "version": 3
   },
   "file_extension": ".py",
   "mimetype": "text/x-python",
   "name": "python",
   "nbconvert_exporter": "python",
   "pygments_lexer": "ipython3",
   "version": "3.6.9"
  }
 },

Just in case the python version listed there also interferes with the Github Actions

@kaitj
Copy link
Collaborator Author

kaitj commented Apr 14, 2021

Just in case the python version listed there also interferes with the Github Actions

Done @josephmje (if this is what you meant).

…graphy_solutions.ipynb

Co-authored-by: Michael Joseph <josephmje.22@gmail.com>
@kaitj
Copy link
Collaborator Author

kaitj commented Apr 14, 2021

Should be fixed now.

@josephmje josephmje merged commit 8173616 into carpentries-incubator:master Apr 14, 2021
@kaitj kaitj deleted the reset_kernel_det_tract branch April 17, 2021 02:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type:bug Code included in the lesson needs to be fixed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants