-
-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DOC: Add discussion section about camera setup #77
DOC: Add discussion section about camera setup #77
Conversation
Following the discussion in #69. A few notes:
|
Deploy preview for carpentries-dmri ready! Built with commit c83e323 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good to me. The sagittal view might actually be sagittal left. Was originally suppose to be sagittal right, and I think I never changed the comment. I can try to create a figure later this week to add to this, but agreed we should figure out if the image filepath is valid.
I'd first merge #76, then do a separate PR to either change the title to sagittal left or generate a sagittal right view. But that is independent of the additions of this PR. I had similar conocerns about the coronal view being posterior (but did not had a detailed look at it): both left/right and anterior/posterior changes can be done in a separate PR if appropriate. OK as for generating the figure as time permits. |
Yeah, I realized I never had a chance to double check orientations. I'll put it on my to do list! |
Leaving this here more as a note for now so its not forgotten / can be double checked.
|
Add discussion section about camera setup.
Add discussion section about camera setup.