Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Small fixes from Carpentries Lab review #444

Merged
merged 3 commits into from
Feb 27, 2024
Merged

Small fixes from Carpentries Lab review #444

merged 3 commits into from
Feb 27, 2024

Conversation

svenvanderburg
Copy link
Collaborator

Copy link

github-actions bot commented Feb 18, 2024

Thank you!

Thank you for your pull request 😃

🤖 This automated message can help you check the rendered files in your submission for clarity. If you have any questions, please feel free to open an issue in {sandpaper}.

If you have files that automatically render output (e.g. R Markdown), then you should check for the following:

  • 🎯 correct output
  • 🖼️ correct figures
  • ❓ new warnings
  • ‼️ new errors

Rendered Changes

🔍 Inspect the changes: https://github.com/carpentries-incubator/deep-learning-intro/compare/md-outputs..md-outputs-PR-444

The following changes were observed in the rendered markdown documents:

 1-introduction.md         | 50 +++++++++++++++++++++++------------------------
 2-keras.md                | 26 ++++++++++++------------
 3-monitor-the-model.md    | 30 ++++++++++++++--------------
 4-advanced-layer-types.md | 20 +++++++++----------
 5-outlook.md              | 18 ++++++++---------
 md5sum.txt                | 38 +++++++++++++++++------------------
 6 files changed, 91 insertions(+), 91 deletions(-)
What does this mean?

If you have source files that require output and figures to be generated (e.g. R Markdown), then it is important to make sure the generated figures and output are reproducible.

This output provides a way for you to inspect the output in a diff-friendly manner so that it's easy to see the changes that occur due to new software versions or randomisation.

⏱️ Updated at 2024-02-18 13:11:42 +0000

Copy link
Collaborator

@carschno carschno left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some markup issues remain (missing alt-text, http instead of https links), but they are not related to these changes.

Copy link
Collaborator

@dsmits dsmits left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

@dsmits dsmits merged commit 9895279 into main Feb 27, 2024
3 checks passed
github-actions bot pushed a commit that referenced this pull request Feb 27, 2024
Auto-generated via {sandpaper}
Source  : 9895279
Branch  : main
Author  : Djura <djura.smits@gmail.com>
Time    : 2024-02-27 10:12:16 +0000
Message : Merge pull request #444 from carpentries-incubator/small-fixes-review

Small fixes from Carpentries Lab review
github-actions bot pushed a commit that referenced this pull request Feb 27, 2024
Auto-generated via {sandpaper}
Source  : a09e23d
Branch  : md-outputs
Author  : GitHub Actions <actions@github.com>
Time    : 2024-02-27 10:14:07 +0000
Message : markdown source builds

Auto-generated via {sandpaper}
Source  : 9895279
Branch  : main
Author  : Djura <djura.smits@gmail.com>
Time    : 2024-02-27 10:12:16 +0000
Message : Merge pull request #444 from carpentries-incubator/small-fixes-review

Small fixes from Carpentries Lab review
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants