-
-
Notifications
You must be signed in to change notification settings - Fork 129
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rewrite of cluster lesson #73
Rewrite of cluster lesson #73
Conversation
That looks good to me. There are probably some possible refinement, but it feel like a better gradual approach. |
@Carreau please have a look at that single review comment I left unresolved for now. Would be cool, to merge soon. |
What is the status of this PR ? , if my latest PR (Fix styling fix#35) is integrated then this one will face conflicts. |
This PR was reviewed by @tkphd yesterday. I am working on a fix to
follow his suggestions.
|
I think we merge this one and plan who is doing what with regards to automatic includes going forwards. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Confirmed: this change produces lola@cray-1
. LGTM.
Optional suggestion is to remove workshop_
from the variable names before merging.
Thanks to @tkphd @Carreau for their reviews. I think this pushed the quality of this PR upwards quite extensively. It's wonderful to see the community helping to create some great material for HPC training. @Sabryr @aturner-epcc Ready to go downstream. |
ssh
/scp