Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improvements to Lessons 1 to 12 #28

Merged
merged 11 commits into from
Feb 18, 2024
Merged

Improvements to Lessons 1 to 12 #28

merged 11 commits into from
Feb 18, 2024

Conversation

manuGil
Copy link
Collaborator

@manuGil manuGil commented Feb 16, 2024

Small corrections to content in lessons one to twelve after checking the exercises.

  • Swapped statement in table for Cons and Pros, Console vs Script.
  • Fix path in code block to download and store exercise data.
  • Fix name function to read CSV files in Explore data lesson
  • Split comments and code in code block for readability
  • Improve text explaining the meaning of the name of the ggplot package
  • Add notice about what packages should be loaded at the beginning of lesson on plotting with ggplot
  • Fix warning of use of deprecate argument size in theme. Use linewidth instead.

@manuGil manuGil added type:enhancement Propose enhancement to the lesson type:formatting Formatting needs to be fixed labels Feb 16, 2024
Copy link

github-actions bot commented Feb 16, 2024

Thank you!

Thank you for your pull request 😃

🤖 This automated message can help you check the rendered files in your submission for clarity. If you have any questions, please feel free to open an issue in {sandpaper}.

If you have files that automatically render output (e.g. R Markdown), then you should check for the following:

  • 🎯 correct output
  • 🖼️ correct figures
  • ❓ new warnings
  • ‼️ new errors

Rendered Changes

🔍 Inspect the changes: https://github.com/carpentries-incubator/r-geospatial-urban/compare/md-outputs..md-outputs-PR-28

The following changes were observed in the rendered markdown documents:

 01-intro-to-r.md                                   |   6 +-
 02-data-structures.md                              |  56 +++++++--
 03-explore-data.md                                 | 133 ++++++++++-----------
 04-intro-to-visualisation.md                       |  97 ++++++++-------
 09-open-and-plot-vector-layers.md                  |   2 +-
 10-explore-and-plot-by-vector-layer-attributes.md  |  54 +++++----
 11-plot-multiple-shape-files.md                    | 114 ++++++++++++++----
 12-handling-spatial-projection-and-crs.md          |  48 ++++++--
 18-import-and-visualise-osm-data.md                |   8 +-
 ...sualise-osm-data-rendered-unnamed-chunk-8-1.png | Bin 76133 -> 76111 bytes
 md5sum.txt                                         |  16 +--
 11 files changed, 333 insertions(+), 201 deletions(-)
What does this mean?

If you have source files that require output and figures to be generated (e.g. R Markdown), then it is important to make sure the generated figures and output are reproducible.

This output provides a way for you to inspect the output in a diff-friendly manner so that it's easy to see the changes that occur due to new software versions or randomisation.

⏱️ Updated at 2024-02-16 19:50:19 +0000

github-actions bot pushed a commit that referenced this pull request Feb 16, 2024
Copy link
Collaborator

@cforgaci cforgaci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @manuGil, for reviewing these episodes. I reviewed all changes, the PR can be merged. You started to reformat the code, but we have to check again that the entire lesson adheres to the tidyverse style guide. I created issue #29 for this.

@cforgaci cforgaci merged commit 49d967f into main Feb 18, 2024
3 checks passed
@cforgaci cforgaci deleted the manuel/review branch February 18, 2024 12:32
github-actions bot pushed a commit that referenced this pull request Feb 18, 2024
Auto-generated via {sandpaper}
Source  : 49d967f
Branch  : main
Author  : Claudiu Forgaci <33600128+cforgaci@users.noreply.github.com>
Time    : 2024-02-18 12:32:34 +0000
Message : Merge pull request #28 from carpentries-incubator/manuel/review

Improvements to Lessons 1 to 12
github-actions bot pushed a commit that referenced this pull request Feb 18, 2024
Auto-generated via {sandpaper}
Source  : 7382fa7
Branch  : md-outputs
Author  : GitHub Actions <actions@github.com>
Time    : 2024-02-18 12:38:21 +0000
Message : markdown source builds

Auto-generated via {sandpaper}
Source  : 49d967f
Branch  : main
Author  : Claudiu Forgaci <33600128+cforgaci@users.noreply.github.com>
Time    : 2024-02-18 12:32:34 +0000
Message : Merge pull request #28 from carpentries-incubator/manuel/review

Improvements to Lessons 1 to 12
@manuGil
Copy link
Collaborator Author

manuGil commented Feb 18, 2024

@cforgaci I use STYLER and reformatted the code blocks using the style guide you mentioned in #30

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type:enhancement Propose enhancement to the lesson type:formatting Formatting needs to be fixed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants