-
-
Notifications
You must be signed in to change notification settings - Fork 72
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update automated email language about publishing self organized workshops #1791
Comments
@pbanaszkiewicz Can you verify if the syntax above is correct? |
@maneesha this condition looks okay:
However if you want to capture scenario when user has consented to publicizing the workshop, but didn't provide the URL, then you'll have to extend the conditional with an What I don't understand is this part:
This doesn't capture Note: once the wording is changed in the production database, I'd like to update |
I actually think it may be better to re-write this email allowing for a few conditions. Assigning to myself to come back to. |
Here's the final template. I have added a few conditionals around url and public/private status, as well as some changes to make the language flow a bit better. @pbanaszkiewicz can you review the logic?
|
Pinging @pbanaszkiewicz Can you take a look at the logic syntax here? |
@maneesha generally looks okay, here's some small issues I found:
|
Thanks for catching these @pbanaszkiewicz
|
@maneesha it's looking good. Don't forget to include the links. |
@pbanaszkiewicz Which links? |
@maneesha: there are 2 places with word "LINK" instead of actual link.
|
I tried to update the template with the text below but get error (
|
@maneesha there was '%' missing in line
|
Finally :-) This has been updated in the admin panel. |
The self organized response template says that the workshop will appear on our website in a few hours -- and this is how things used to be.
Current text:
However, because we now have the public/private status for workshop requests, the workshop will only appear on the website conditionally. I have changed the current text to be
Ideally I'd like to have conditional text in the template. I think this is what it should look like but wanted to raise it here before updating (and possibly breaking) the logic in the text. We want to say it will be published if we have a url and status is public.
The text was updated successfully, but these errors were encountered: