Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ask for consents during instructor training application #2162

Closed
fmichonneau opened this issue Apr 22, 2022 · 6 comments · Fixed by #2363
Closed

Ask for consents during instructor training application #2162

fmichonneau opened this issue Apr 22, 2022 · 6 comments · Fixed by #2363
Assignees
Projects
Milestone

Comments

@fmichonneau
Copy link
Contributor

When people submit an application for instructor training (https://amy.carpentries.org/forms/request_training/), the consents at the bottom of the page should list all the (non-archived) required consents.

@maneesha maneesha added this to To do in Consents via automation Dec 19, 2022
@pbanaszkiewicz pbanaszkiewicz self-assigned this Mar 5, 2023
@pbanaszkiewicz pbanaszkiewicz moved this from To do to In progress in Consents Mar 5, 2023
@pbanaszkiewicz pbanaszkiewicz added this to the v4.1 milestone Mar 5, 2023
pbanaszkiewicz added a commit that referenced this issue Mar 19, 2023
It contains common fields and methods used in descendant classes.

New descendant to be introduced in next commit.
@pbanaszkiewicz
Copy link
Contributor

@maneesha @froggleston

Currently we recognize "consents required for creating a profile":
obraz

Which of these should be presented to the user on the instructor training request form?

pbanaszkiewicz added a commit that referenced this issue Mar 19, 2023
…ing consent fields

This solution is similar to the approach from BaseTermConsentsForm.
@maneesha
Copy link
Contributor

As we discussed today, all consents should be there. The one for "making profile public" should read:

Allow posting your name and any public profile you list (website, Twitter) on our website only after you complete Instructor Training certification. Emails will not be posted.

@pbanaszkiewicz
Copy link
Contributor

@maneesha @froggleston

I have additional question about existing checkboxes:
obraz

I was able to submit a test training request without any of these fields ticked. Is this intended? I can change this behavior to force people to accept these.

@maneesha
Copy link
Contributor

For now, please keep the other questions are they are. This is part of the larger changes we want to make to the instructor training application, so we will review this all together in a separate issue/project.

@froggleston
Copy link

froggleston commented Mar 27, 2023 via email

@pbanaszkiewicz
Copy link
Contributor

@maneesha @froggleston can you create a new story for that?

pbanaszkiewicz added a commit that referenced this issue Mar 31, 2023
It contains common fields and methods used in descendant classes.

New descendant to be introduced in next commit.
pbanaszkiewicz added a commit that referenced this issue Mar 31, 2023
…ing consent fields

This solution is similar to the approach from BaseTermConsentsForm.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Development

Successfully merging a pull request may close this issue.

4 participants