Membership duration warning #1771
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Show membership duration warning if the membership was created with invalid duration (ie. != full year). The year calculation is based on replacing year with start_year+1 and comparing to selected end date. The warning will only show up after creating the membership, not on every request to the membership details page.
1. Add JavaScript logic to set a new agreement end date when user enters start date. The new end date will be start date with year incremented by 1. 2. Remove default value out of Membership model. It was causing the prepopulation in the first place. 3. The change in default value results in migration.
Ensure the agreement start is sooner than the agreement end date.
|
Correct - start and end date should always be required. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Improve agreement start/end date handling and UX.
TODO: I asked a question about membership agreement start/end values being empty. I think we shouldn't allow for them being empty, but I want to receive confirmation from @maneesha.