-
-
Notifications
You must be signed in to change notification settings - Fork 72
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Colors for different builds #2357
Colors for different builds #2357
Conversation
An indication that you are on a test or local build should always be visible. I'm ok with having the bar always be visible but if others feel it takes up too much space, I also like Eli's suggestions of changing the menu colors. We can also consider a different body background color for local and test builds. Anything that would indicate to the user that they are in a different space. |
I was following this design from Django docs for development version: https://docs.djangoproject.com/en/dev/ |
I'd favour sticky at the top so it's harder to miss. It doesn't take up too much space and I'll get used to it! |
666bad9
to
f7ae908
Compare
I didn't want to change navigation bar or page background colors because it would impact readability or require a lot of further work to improve CSS of elements displayed in the navigation bar or on the page. |
I'm happy with this version. |
Looks good to me! |
"local" will be yellow tape across top. "testing" will be red tape across top. "production" will not show up at all.
Either local or testing.
f7ae908
to
28359f6
Compare
This fixes #2322.
There will be 2 banners available: local and testing.
Local looks like this:
Testing looks like this:
Every site will have this banner. It will stay on top, but will hide beneath the navigation bar: