Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Colors for different builds #2357

Merged
merged 5 commits into from
Mar 13, 2023

Conversation

pbanaszkiewicz
Copy link
Contributor

This fixes #2322.

There will be 2 banners available: local and testing.

Local looks like this:
obraz

Testing looks like this:
obraz

Every site will have this banner. It will stay on top, but will hide beneath the navigation bar:
banner_hides_beneath

amy/static/css/amy.css Outdated Show resolved Hide resolved
@elichad
Copy link
Contributor

elichad commented Mar 6, 2023

Could we also have a smaller indicator in the nav bar so that there's always something visible even when scrolled down? Example below. (We could just keep the full banner visible, but it's quite noisy and takes up space)

Top of page:
Screenshot with local banner and yellow 'Local' indicator next to the AMY home link in the nav bar

Scrolled down:
Screenshot with banner hidden but nav bar indicator still present

@maneesha
Copy link
Contributor

maneesha commented Mar 6, 2023

An indication that you are on a test or local build should always be visible. I'm ok with having the bar always be visible but if others feel it takes up too much space, I also like Eli's suggestions of changing the menu colors. We can also consider a different body background color for local and test builds. Anything that would indicate to the user that they are in a different space.

@pbanaszkiewicz
Copy link
Contributor Author

@elichad @maneesha I think we could make it sticky to the bottom of the page and it would not hide. What do you think?

@pbanaszkiewicz
Copy link
Contributor Author

I was following this design from Django docs for development version: https://docs.djangoproject.com/en/dev/

@elichad
Copy link
Contributor

elichad commented Mar 6, 2023

I'd favour sticky at the top so it's harder to miss. It doesn't take up too much space and I'll get used to it!

@pbanaszkiewicz
Copy link
Contributor Author

obraz

Changes:

  1. banner stays on top and is never covered by the navigation menu
  2. banner background no longer contains diagonal stripes
  3. sharper color contrast between font color and background color for increased readability

@pbanaszkiewicz pbanaszkiewicz force-pushed the feature/2322-colors-for-different-builds branch from 666bad9 to f7ae908 Compare March 10, 2023 19:48
@pbanaszkiewicz
Copy link
Contributor Author

@maneesha @elichad how do you like this version?

@pbanaszkiewicz
Copy link
Contributor Author

I didn't want to change navigation bar or page background colors because it would impact readability or require a lot of further work to improve CSS of elements displayed in the navigation bar or on the page.

@elichad
Copy link
Contributor

elichad commented Mar 13, 2023

I'm happy with this version.

@maneesha
Copy link
Contributor

Looks good to me!

@pbanaszkiewicz pbanaszkiewicz force-pushed the feature/2322-colors-for-different-builds branch from f7ae908 to 28359f6 Compare March 13, 2023 20:44
@pbanaszkiewicz pbanaszkiewicz merged commit b7f9377 into develop Mar 13, 2023
CI/CD for development branch automation moved this from In progress to Done Mar 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

Different colour scheme for test-amy / local builds
3 participants