Reduce hardcoding of consent labels in UI #2361
Conversation
| migrations.AddField( | ||
| model_name="term", | ||
| name="short_description", | ||
| field=models.CharField(null=True, max_length=100), |
There was a problem hiding this comment.
You should be able to create the field with "" as default value, therefore there should be no need switch null=True and then null=False in a migration.
There was a problem hiding this comment.
Wouldn't you then have to do the same thing with blank=True and blank=False instead? I don't think we want this field to be permitted to be blank as it may appear in the UI through lines like this https://github.com/carpentries/amy/pull/2361/files#diff-a97c97acc5cd76b1c48999bacdc2b399b62f678806ab48b559dcc0944c366536R278
There was a problem hiding this comment.
I think blank is only applied when creating model instances. You definitely should be fine if you provide one-off value for the migration (default value of ""). makemigrations may even ask you for it.
| @@ -37,15 +37,15 @@ | |||
| </th><td>{{ user.secondary_email|default:"—" }}</td></tr> | |||
| <tr><th>Gender:</th><td>{{ user.get_gender_display }}{{ user.gender_other }}</td></tr> | |||
| <tr> | |||
| <th>Can we contact you?</th> | |||
| <th>{{ consents_content.may_contact }}</th> | |||
There was a problem hiding this comment.
Is this the same as consents.public_profile.term.content? If yes, then I'm not sure we need consents_content object.
There was a problem hiding this comment.
The content is the same, but if the user hasn't set that consent, consents.public_profile won't exist.
|
Merging now. I've also made that change to the content of |
elichad
deleted the
feature/2302-Consents-add-admin-field-text-representation-of-a-consent-term
branch
Fixes #2302 .
Also propose updating the
contentfield of thepublic-profileconsent to "Do you consent to publish your profileon The Carpentries website?" in the AMY Django admin interface.