-
-
Notifications
You must be signed in to change notification settings - Fork 72
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Titanium membership variant, remove prepopulation of membership benefits #2382
Add Titanium membership variant, remove prepopulation of membership benefits #2382
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please bring unpinned black. Otherwise the changes look good.
Pipfile
Outdated
@@ -48,7 +48,7 @@ requests-mock = "~=1.9.3" | |||
tblib = "~=1.7.0" | |||
flake8 = "*" | |||
mypy = "*" | |||
black = "*" | |||
black = "~=22.12.0" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think I'd rather have black unpinned and allow it to reformat some files now.
Plus I don't think you should be seeing reformatting applied to workshops/views.py
since this file is not touched by your changes and would not trigger pre-commit hook.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I wrote the wrong name 🤦 it was reformatting workshops/models.py
. As I've reverted it and not made further changes to that file, the formatting won't change now anyway.
Perhaps we should bump our CI linting, pre-commit file etc. to use black 23.x and reformat the whole repo accordingly once we have v4.1 ready to go?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Perhaps we should bump our CI linting, pre-commit file etc. to use black 23.x and reformat the whole repo accordingly once we have v4.1 ready to go?
That's a good idea.
This reverts commit 4a1af8b.
Fixes #2368, fixes #2100.
Pins black to 22.x (matching our precommit/lint jobs) to avoid some reformatting elsewhere in
workshops/views.py
that happens under black 23.x.