Remove 'evaluated_by' and 'discarded' fields from TrainingProgress #2416
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
elichad
added this to In Progress
in Instructor Training - New Checkout Process
via automation
pbanaszkiewicz
approved these changes
May 15, 2023
amy/trainings/views.py
Outdated
| @@ -134,31 +124,16 @@ def all_trainees(request): | |||
| if request.method == "POST" and "discard" in request.POST: | |||
| # Bulk discard progress of selected trainees | |||
| form = BulkAddTrainingProgressForm() | |||
There was a problem hiding this comment.
Should these 3 lines remain? We could probably leave the "elif" from L149 as "if" and skip the check for "discard" in POST since that form was removed.
There was a problem hiding this comment.
Good point. I'll make this change.
Instructor Training - New Checkout Process
automation
moved this from In Progress
to Done
May 16, 2023
|
Hey @elichad I was looking over git log history and I noticed that this PR was merged into a feature branch. Do you want to merge these changes into development branch, too? |
|
@pbanaszkiewicz my plan is to merge the checkout work into this |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2409
Fixes #2407
Discussed with instructor training team and agreed that the very few existing TrainingProgress records which are currently marked as discarded will be otherwise unchanged (so some will become valid passes). Manually confirmed in AMY that this will not make anyone eligible for an instructor badge who wasn't eligible before.