-
-
Notifications
You must be signed in to change notification settings - Fork 72
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adjust consents docs to support a less technical audience #2463
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm no expert in English, so only minor suggestions you can take or not.
docs/amy_database_structure.md
Outdated
`consents_termoption` - Stores all options for a stored `Term` in AMY. `TermOptions` are displayed when the user is asked to consent to a `Term`, | ||
and are considered answer choices for the `Term`. | ||
`consents_termoption` - Stores all options for all terms in AMY. Options are displayed when the user is asked to consent to a particular term, | ||
and are considered answer choices for are term. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think there's a typo somewhere in this line. I'm guessing that the whole sentence could and in L242 ("Options are displayed when the user is asked to consent to a particular term."), and L243 could be a new sentence: "TermOptions are answer choices for the term". What do you think?
Co-authored-by: Piotr Banaszkiewicz <piotr@banaszkiewicz.org>
All good suggestions, thanks @pbanaszkiewicz! I'll wait for @maneesha to also take a look before merging |
looks good to me! |
@elichad Have I moved this by accident to Email Automation project, or was it someone else? |
@pbanaszkiewicz it looks like an accident to me. I'll take it out of that project |
In line with #2422, makes the "Database Structure" docs for consents a bit less technical.