Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adjust consents docs to support a less technical audience #2463

Merged
merged 3 commits into from
Jul 17, 2023

Conversation

elichad
Copy link
Contributor

@elichad elichad commented Jul 10, 2023

In line with #2422, makes the "Database Structure" docs for consents a bit less technical.

@elichad elichad added this to the v4.2 milestone Jul 10, 2023
@elichad elichad requested a review from maneesha July 10, 2023 16:44
@elichad elichad self-assigned this Jul 10, 2023
Copy link
Contributor

@pbanaszkiewicz pbanaszkiewicz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm no expert in English, so only minor suggestions you can take or not.

`consents_termoption` - Stores all options for a stored `Term` in AMY. `TermOptions` are displayed when the user is asked to consent to a `Term`,
and are considered answer choices for the `Term`.
`consents_termoption` - Stores all options for all terms in AMY. Options are displayed when the user is asked to consent to a particular term,
and are considered answer choices for are term.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think there's a typo somewhere in this line. I'm guessing that the whole sentence could and in L242 ("Options are displayed when the user is asked to consent to a particular term."), and L243 could be a new sentence: "TermOptions are answer choices for the term". What do you think?

docs/amy_database_structure.md Outdated Show resolved Hide resolved
docs/amy_database_structure.md Outdated Show resolved Hide resolved
docs/amy_database_structure.md Outdated Show resolved Hide resolved
elichad and others added 2 commits July 13, 2023 10:04
Co-authored-by: Piotr Banaszkiewicz <piotr@banaszkiewicz.org>
@elichad
Copy link
Contributor Author

elichad commented Jul 13, 2023

All good suggestions, thanks @pbanaszkiewicz! I'll wait for @maneesha to also take a look before merging

@maneesha
Copy link
Contributor

looks good to me!

@elichad elichad merged commit 16ddbf5 into develop Jul 17, 2023
7 checks passed
@elichad elichad deleted the feature/update-consents-db-docs branch July 17, 2023 12:48
@pbanaszkiewicz
Copy link
Contributor

@elichad Have I moved this by accident to Email Automation project, or was it someone else?

@elichad
Copy link
Contributor Author

elichad commented Jul 25, 2023

@pbanaszkiewicz it looks like an accident to me. I'll take it out of that project

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants