Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

26-11-20: Arabic terms for merged PR #218 and PR #223 aren't rendered in the website. #225

Closed
BatoolMM opened this issue Nov 26, 2020 · 12 comments
Labels
bug Something isn't working

Comments

@BatoolMM
Copy link
Member

This is to report a bug in the glosario repo.

It seems that recently merged PRs (PR #218 and PR #223) for Arabic translation aren't rendered on the website. In order to examine the issue, I tried to build the website locally but it's complaining.

GitHub Metadata: No GitHub API authentication could be found. Some fields may be missing or have incorrect data.
  Liquid Exception: "<USERNAME>/<PROJECT>" is invalid as a repository identifier. Use the user/repo (String) format, or the repository ID (Integer), or a hash containing :repo and :user keys. in /_layouts/page.html
jekyll 3.9.0 | Error:  "<USERNAME>/<PROJECT>" is invalid as a repository identifier. Use the user/repo (String) format, or the repository ID (Integer), or a hash containing :repo and :user keys.

This may have to be related to the changes introduced in PR #207 for letter links. I also can't see the letter links in my Chrome browser.

My apologies if no enough details are given in this report.

@BatoolMM BatoolMM added the bug Something isn't working label Nov 26, 2020
@baileythegreen
Copy link
Contributor

baileythegreen commented Nov 26, 2020

@BatoolMM , the repository identifier may need to be modified in your local clone to get it to render locally. I keep having to change it to baileythegreen/glosario to get it to render.

Not seeing the links in your browser is odd. I can see them in mine right now.

Screen Shot 2020-11-26 at 12 21 08

@baileythegreen
Copy link
Contributor

@BatoolMM Can you attach a screenshot of what you see in the browser?

@BatoolMM
Copy link
Member Author

@baileythegreen, this is strange!

Screenshot 2020-11-26 at 15 27 15

@baileythegreen
Copy link
Contributor

baileythegreen commented Nov 26, 2020

@BatoolMM The strangest part for me is the url I see in your picture. Try this link:

https://carpentries.github.io/glosario/ar/

I'm not sure why both would work, but differ, but maybe that's it.

@baileythegreen
Copy link
Contributor

Update: I tried your url, and it looks like what the site looked like before I did things to it. I think that is just the html file, without any of the CSS styling (and therefore no letter links). No idea why that doesn't include all of the new terms.

@baileythegreen
Copy link
Contributor

For future reference, the correct form for the website url is:

https://carpentries.github.io/glosario

@BatoolMM
Copy link
Member Author

It makes sense now but my url is the one displayed on the main page about of the repo (top right).

Screenshot 2020-11-26 at 15 41 25

@baileythegreen
Copy link
Contributor

@BatoolMM The url you see on that page is set by a user in one of the 'About' fields, and so it is possible for it to be wrong. I can't change that, but you seem to have the 'Settings' gear, so you could.

In the Settings tab, you should look for the GitHub Pages section, and grab the correct url from there (this is an example from one of my sites, since I can't access the Glosario one):

Screen Shot 2020-11-26 at 12 55 51

@BatoolMM
Copy link
Member Author

Yes, I've changed it but I want to double-check with @fmichonneau, just to clarify why are there two URLs?

Regarding rendering the website locally, can I ask what you meant by changing the repository identifier? Do you mean inside.git/config?

@baileythegreen
Copy link
Contributor

baileythegreen commented Nov 26, 2020

In my version of the _config.yml file I have the name of my version of the repository, baileythegreen/glosario.

Regarding the two URLs, one is just the location of ar.html (or the index.html file, following the link you did, originally) file on the internet. You can access the raw versions of all of the files this way:

Screen Shot 2020-11-26 at 13 15 35

This is a subtle difference between the locations of the raw files and the url at which the site is rendered.

@BatoolMM
Copy link
Member Author

Thank you @baileythegreen. Everything makes sense now.
BTW, I love the new layout with the letter links :)

@baileythegreen
Copy link
Contributor

@BatoolMM Thank you. It's my first major foray into html/CSS. Hopefully I can improve it in the future to make it even nicer.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants