Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add new term to arabic #223

Merged
merged 8 commits into from
Nov 24, 2020
Merged

Add new term to arabic #223

merged 8 commits into from
Nov 24, 2020

Conversation

WafaaMoh
Copy link
Contributor

Author:

  • Wafaa

Language:

  • Arabic

Terms defined:

  • anonymous function

Editor

Assign the PR based on the language to the following person:

Language Person
Afrikaans @jsteyn, @elletjies
Arabic @BatoolMM
English @zkamvar
French @fmichonneau
Portuguese @beatrizmilz
Spanish @ian-flores

@BatoolMM BatoolMM added the lang: ar issues and PR for Arabic entries label Nov 20, 2020
BatoolMM
BatoolMM reviewed Nov 20, 2020
View reviewed changes
glossary.yml Outdated Show resolved Hide resolved
BatoolMM
BatoolMM reviewed Nov 20, 2020
View reviewed changes
glossary.yml Outdated Show resolved Hide resolved
BatoolMM
BatoolMM reviewed Nov 20, 2020
View reviewed changes
glossary.yml Outdated Show resolved Hide resolved
WafaaMoh and others added 3 commits November 20, 2020 19:26
@WafaaMoh @BatoolMM
Update glossary.yml
f7d75cb 
Co-authored-by: Batool <53487593+BatoolMM@users.noreply.github.com>
@WafaaMoh @BatoolMM
Update glossary.yml
0572660 
Co-authored-by: Batool <53487593+BatoolMM@users.noreply.github.com>
@WafaaMoh @BatoolMM
Update glossary.yml
9d615bf 
Co-authored-by: Batool <53487593+BatoolMM@users.noreply.github.com>
BatoolMM
BatoolMM reviewed Nov 20, 2020
View reviewed changes
glossary.yml Outdated Show resolved Hide resolved
BatoolMM
BatoolMM reviewed Nov 20, 2020
View reviewed changes
glossary.yml Outdated Show resolved Hide resolved
WafaaMoh and others added 2 commits November 20, 2020 19:34
@WafaaMoh @BatoolMM
Update glossary.yml
6c4b9cc 
Co-authored-by: Batool <53487593+BatoolMM@users.noreply.github.com>
@WafaaMoh @BatoolMM
Update glossary.yml
e88c020 
Co-authored-by: Batool <53487593+BatoolMM@users.noreply.github.com>
BatoolMM
BatoolMM reviewed Nov 20, 2020
View reviewed changes
Copy link
Member

@BatoolMM BatoolMM left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

مُعظم المشاكل هي مشاكل في المسافات وهذا طبيعي

glossary.yml Outdated Show resolved Hide resolved
@BatoolMM
Copy link
Member

All the indentations errors were fixed but I am not sure why make check still fails.

It keeps giving this error:

make: *** [check] Error 1
Makefile:34: recipe for target 'check' failed
Error: Process completed with exit code 2.

Can you have a look @fmichonneau, please?

@fmichonneau fmichonneau merged commit af3b338 into carpentries:master Nov 24, 2020
@fmichonneau
Copy link
Contributor

Thanks! there was an extra space in the reference.

@BatoolMM BatoolMM mentioned this pull request Nov 26, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BatoolMM BatoolMM BatoolMM left review comments

@fmichonneau fmichonneau fmichonneau approved these changes

Assignees
No one assigned
Labels
lang: ar issues and PR for Arabic entries
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@WafaaMoh @BatoolMM @fmichonneau