New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Initial draft of the 'Stay on target' lesson #59
Conversation
Thank you!Thank you for your pull request 😃 🤖 This automated message can help you check the rendered files in your submission for clarity. If you have any questions, please feel free to open an issue in {sandpaper}. If you have files that automatically render output (e.g. R Markdown), then you should check for the following:
Rendered Changes🔍 Inspect the changes: https://github.com/carpentries/lesson-development-training/compare/md-outputs..md-outputs-PR-59 The following changes were observed in the rendered markdown documents:
What does this mean?If you have source files that require output and figures to be generated (e.g. R Markdown), then it is important to make sure the generated figures and output are reproducible. This output provides a way for you to inspect the output in a diff-friendly manner so that it's easy to see the changes that occur due to new software versions or randomisation. ⏱️ Updated at 2022-06-08 10:57:18 +0000 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice draft @anenadic! Left a few inline comments. Sorry I accidentally submitted a couple as individual suggestions. Not a changed line but maybe line 131 might be better as an instructor note.
I'm still feeling like hidden curriculum doesn't flow well in the lesson. Maybe a callout?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am +1 to all of @sstevens2's suggestions, and have made a few small comments of my own as well. Otherwise, this looks good @anenadic - thanks!
Co-authored-by: Sarah Stevens <sarah.stevens@wisc.edu>
Co-authored-by: Sarah Stevens <sarah.stevens@wisc.edu>
Co-authored-by: Sarah Stevens <sarah.stevens@wisc.edu>
Co-authored-by: Sarah Stevens <sarah.stevens@wisc.edu>
Co-authored-by: Sarah Stevens <sarah.stevens@wisc.edu>
Co-authored-by: Sarah Stevens <sarah.stevens@wisc.edu>
Co-authored-by: Sarah Stevens <sarah.stevens@wisc.edu>
Co-authored-by: Sarah Stevens <sarah.stevens@wisc.edu>
Co-authored-by: Toby Hodges <tobyhodges@carpentries.org>
Co-authored-by: Toby Hodges <tobyhodges@carpentries.org>
Totally fine, go for it!
Which one is line 131 now @sstevens2 so I can address it?
I was struggling with hidden curriculum myself - I agree that it could go into a callout. I have fixed this via 131b02f - see if this works better @sstevens2. Also a nudge to @tobyhodges to check this change. |
…y to long-term memory
It is an interesting concept for lesson developers to consider. Maybe we can find a place to spend more time on it in the future? |
Line 131 right now: "(this exercise will only work if participants have sufficient knowledge of their partner's topic)" |
Great stuff @anenadic 🙌 |
Auto-generated via {sandpaper} Source : 59da513 Branch : md-outputs Author : GitHub Actions <actions@github.com> Time : 2022-06-08 13:12:57 +0000 Message : markdown source builds Auto-generated via {sandpaper} Source : 5e15cc5 Branch : main Author : Toby Hodges <tobyhodges@carpentries.org> Time : 2022-06-08 13:10:26 +0000 Message : Merge pull request #59 from carpentries/09-stay-on-target Initial draft of the 'Stay on target' lesson
Ready for review!