Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Initial draft of the 'Stay on target' lesson #59

Merged
merged 14 commits into from Jun 8, 2022
Merged

Conversation

anenadic
Copy link
Collaborator

@anenadic anenadic commented Jun 7, 2022

Ready for review!

  • is there too much content on MCQs?
  • do we need more on guided practice (e.g. an extra sentence to explain things a bit more)

github-actions bot pushed a commit that referenced this pull request Jun 7, 2022
@github-actions
Copy link

github-actions bot commented Jun 7, 2022

Thank you!

Thank you for your pull request 😃

🤖 This automated message can help you check the rendered files in your submission for clarity. If you have any questions, please feel free to open an issue in {sandpaper}.

If you have files that automatically render output (e.g. R Markdown), then you should check for the following:

  • 🎯 correct output
  • 🖼️ correct figures
  • ❓ new warnings
  • ‼️ new errors

Rendered Changes

🔍 Inspect the changes: https://github.com/carpentries/lesson-development-training/compare/md-outputs..md-outputs-PR-59

The following changes were observed in the rendered markdown documents:

 09-formative-assessment.md | 103 +++++++++++++++++++++++++++++++++++----------
 md5sum.txt                 |   2 +-
 2 files changed, 81 insertions(+), 24 deletions(-)
What does this mean?

If you have source files that require output and figures to be generated (e.g. R Markdown), then it is important to make sure the generated figures and output are reproducible.

This output provides a way for you to inspect the output in a diff-friendly manner so that it's easy to see the changes that occur due to new software versions or randomisation.

⏱️ Updated at 2022-06-08 10:57:18 +0000

@anenadic anenadic requested a review from mkuzak June 7, 2022 16:57
Copy link
Collaborator

@sstevens2 sstevens2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice draft @anenadic! Left a few inline comments. Sorry I accidentally submitted a couple as individual suggestions. Not a changed line but maybe line 131 might be better as an instructor note.

I'm still feeling like hidden curriculum doesn't flow well in the lesson. Maybe a callout?

episodes/09-formative-assessment.md Outdated Show resolved Hide resolved
episodes/09-formative-assessment.md Outdated Show resolved Hide resolved
episodes/09-formative-assessment.md Outdated Show resolved Hide resolved
episodes/09-formative-assessment.md Outdated Show resolved Hide resolved
episodes/09-formative-assessment.md Outdated Show resolved Hide resolved
episodes/09-formative-assessment.md Outdated Show resolved Hide resolved
Copy link
Member

@tobyhodges tobyhodges left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am +1 to all of @sstevens2's suggestions, and have made a few small comments of my own as well. Otherwise, this looks good @anenadic - thanks!

episodes/09-formative-assessment.md Outdated Show resolved Hide resolved
episodes/09-formative-assessment.md Outdated Show resolved Hide resolved
episodes/09-formative-assessment.md Outdated Show resolved Hide resolved
anenadic and others added 5 commits June 8, 2022 10:28
Co-authored-by: Sarah Stevens <sarah.stevens@wisc.edu>
Co-authored-by: Sarah Stevens <sarah.stevens@wisc.edu>
Co-authored-by: Sarah Stevens <sarah.stevens@wisc.edu>
Co-authored-by: Sarah Stevens <sarah.stevens@wisc.edu>
Co-authored-by: Sarah Stevens <sarah.stevens@wisc.edu>
github-actions bot pushed a commit that referenced this pull request Jun 8, 2022
github-actions bot pushed a commit that referenced this pull request Jun 8, 2022
Co-authored-by: Sarah Stevens <sarah.stevens@wisc.edu>
github-actions bot pushed a commit that referenced this pull request Jun 8, 2022
github-actions bot pushed a commit that referenced this pull request Jun 8, 2022
github-actions bot pushed a commit that referenced this pull request Jun 8, 2022
anenadic and others added 2 commits June 8, 2022 10:34
Co-authored-by: Sarah Stevens <sarah.stevens@wisc.edu>
Co-authored-by: Sarah Stevens <sarah.stevens@wisc.edu>
github-actions bot pushed a commit that referenced this pull request Jun 8, 2022
Co-authored-by: Toby Hodges <tobyhodges@carpentries.org>
github-actions bot pushed a commit that referenced this pull request Jun 8, 2022
github-actions bot pushed a commit that referenced this pull request Jun 8, 2022
github-actions bot pushed a commit that referenced this pull request Jun 8, 2022
anenadic and others added 2 commits June 8, 2022 11:22
@anenadic
Copy link
Collaborator Author

anenadic commented Jun 8, 2022

Nice draft @anenadic! Left a few inline comments. Sorry I accidentally submitted a couple as individual suggestions.

Totally fine, go for it!

Not a changed line but maybe line 131 might be better as an instructor note.

Which one is line 131 now @sstevens2 so I can address it?

I'm still feeling like hidden curriculum doesn't flow well in the lesson. Maybe a callout?

I was struggling with hidden curriculum myself - I agree that it could go into a callout. I have fixed this via 131b02f - see if this works better @sstevens2. Also a nudge to @tobyhodges to check this change.

github-actions bot pushed a commit that referenced this pull request Jun 8, 2022
github-actions bot pushed a commit that referenced this pull request Jun 8, 2022
@sstevens2
Copy link
Collaborator

Yeah, the hidden curriculum part was probably too much information. I liked it because I think it encourages trainees to consider how the written lesson content and the way it is taught combine together to create an impression on the learner. Using an Instructor Note here feels like a good compromise.

It is an interesting concept for lesson developers to consider. Maybe we can find a place to spend more time on it in the future?

@sstevens2
Copy link
Collaborator

sstevens2 commented Jun 8, 2022

@anenadic

Which one is line 131 now @sstevens2 so I can address it?

Line 131 right now: "(this exercise will only work if participants have sufficient knowledge of their partner's topic)"

@tobyhodges
Copy link
Member

Great stuff @anenadic 🙌

@tobyhodges tobyhodges merged commit 5e15cc5 into main Jun 8, 2022
github-actions bot pushed a commit that referenced this pull request Jun 8, 2022
Auto-generated via {sandpaper}
Source  : 5e15cc5
Branch  : main
Author  : Toby Hodges <tobyhodges@carpentries.org>
Time    : 2022-06-08 13:10:26 +0000
Message : Merge pull request #59 from carpentries/09-stay-on-target

Initial draft of the 'Stay on target' lesson
github-actions bot pushed a commit that referenced this pull request Jun 8, 2022
Auto-generated via {sandpaper}
Source  : 59da513
Branch  : md-outputs
Author  : GitHub Actions <actions@github.com>
Time    : 2022-06-08 13:12:57 +0000
Message : markdown source builds

Auto-generated via {sandpaper}
Source  : 5e15cc5
Branch  : main
Author  : Toby Hodges <tobyhodges@carpentries.org>
Time    : 2022-06-08 13:10:26 +0000
Message : Merge pull request #59 from carpentries/09-stay-on-target

Initial draft of the 'Stay on target' lesson
@tobyhodges tobyhodges deleted the 09-stay-on-target branch June 10, 2022 14:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants