Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

404 page does not render correctly for any arbitrary invalid URL #335

Closed
jhlegarreta opened this issue Apr 3, 2021 · 4 comments
Closed

Comments

@jhlegarreta
Copy link
Contributor

The 404 page seems to work correctly when introducing an invalid URL from the main page, e.g.
https://carpentries.github.io/lesson-example/random

However, the style is not correctly applied when introducing an invalid URL from any other page/episode or any other part of the URL, e.g.
https://carpentries.github.io/lesson-example/03-organization/index1.html
https://carpentries.github.io/lesson-example/03-organization1/index.html

@maxim-belkin
Copy link
Contributor

Thanks @jhlegarreta. Could you please submit the issue (and the fix) to carpentries/styles?

@jhlegarreta
Copy link
Contributor Author

@maxim-belkin Unfortunately, I do not know what the fix is 😔, but I can open the issue in the carpentries/styles and close it here if that is the right place for the issue.

@maxim-belkin
Copy link
Contributor

Ah, OK. I assumed that the linked (merged) pr has a fix. Yes, please submit it to carpentries/styles.

@jhlegarreta
Copy link
Contributor Author

Keeping track of the issue in carpentries/styles#568

Closing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants