Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

404 page does not apply the style for any arbitrary invalid URL #568

Closed
jhlegarreta opened this issue Apr 3, 2021 · 1 comment
Closed
Labels
type:bug Code included in the lesson needs to be fixed type:template and tools Issue about template and tools

Comments

@jhlegarreta
Copy link

The 404 page seems to work correctly when introducing an invalid URL from the main page, e.g.
https://carpentries.github.io/lesson-example/random

However, the style is not correctly applied when introducing an invalid URL from any other page/episode or any other part of the URL, e.g.
https://carpentries.github.io/lesson-example/03-organization/index1.html
https://carpentries.github.io/lesson-example/03-organization1/index.html

@jhlegarreta
Copy link
Author

I can confirm that applying the fix in #578 solved the issue in the repository where this was first detected:
https://github.com/carpentries-incubator/SDC-BIDS-dMRI

e.g.

carpentries_404_outer

and

carpentries_404_inner

Thanks for all the good wok.

Closing the issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type:bug Code included in the lesson needs to be fixed type:template and tools Issue about template and tools
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants