Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

librarycarpentry/lc-r #19

Closed
zkamvar opened this issue Mar 23, 2023 · 1 comment
Closed

librarycarpentry/lc-r #19

zkamvar opened this issue Mar 23, 2023 · 1 comment
Labels
01 May Lesson to be transitioned on 01 May lesson A Carpentries Lesson To Transition status: in progress This label is for lessons that are currently being processed, but still have issues status: ready This label is for lessons that are ready for transition to the workbench

Comments

@zkamvar
Copy link
Contributor

zkamvar commented Mar 23, 2023 •
edited

This serves as the log to record issues in the https://github.com/LibraryCarpentry/lc-r lesson:

  1. Explicit <figure> tags around the R Markdown chunks to produce figures update figures LibraryCarpentry/lc-r#85
  2. discontinuous block quotes, which is not a problem for kramdown, but is a problem for commonmark.
    a. first example block
    b. second example block
  3. The setup code is kept within bin/ and needs to be moved to episodes/files
zkamvar added a commit that referenced this issue Mar 23, 2023
@zkamvar
add parsing for discontinuous blocks
7389a4e 
This will address #19
@zkamvar zkamvar mentioned this issue Mar 29, 2023
Closed
@zkamvar zkamvar added status: ready This label is for lessons that are ready for transition to the workbench status: in progress This label is for lessons that are currently being processed, but still have issues labels Apr 11, 2023
@zkamvar zkamvar reopened this Apr 11, 2023
@zkamvar zkamvar added the lesson A Carpentries Lesson To Transition label Apr 11, 2023
@zkamvar zkamvar changed the title LibraryCarpentry/lc-r librarycarpentry/lc-r Apr 14, 2023
@zkamvar zkamvar mentioned this issue Apr 25, 2023
Closed
@zkamvar zkamvar added the 01 May Lesson to be transitioned on 01 May label Apr 28, 2023
@zkamvar
Copy link
Contributor Author

zkamvar commented May 1, 2023

fixed in 91f7ddd

@zkamvar zkamvar closed this as completed May 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
01 May Lesson to be transitioned on 01 May lesson A Carpentries Lesson To Transition status: in progress This label is for lessons that are currently being processed, but still have issues status: ready This label is for lessons that are ready for transition to the workbench
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@zkamvar