Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

librarycarpentry/lc-sql #69

Closed
5 tasks done
zkamvar opened this issue Apr 10, 2023 · 3 comments
Closed
5 tasks done

librarycarpentry/lc-sql #69

zkamvar opened this issue Apr 10, 2023 · 3 comments
Labels
02 May lesson A Carpentries Lesson To Transition status: ready This label is for lessons that are ready for transition to the workbench

Comments

@zkamvar
Copy link
Contributor

zkamvar commented Apr 10, 2023 •
edited

tracking issue for https://github.com/librarycarpentry/lc-sql

episodes/06-joins-aliases.md:39 [missing file]: [](assets/fig/left-join-articles-journals_40.png)
episodes/06-joins-aliases.md:51 [missing file]: [](assets/fig/articles-erd-v02.png)
episodes/08-database-design.md:31 [missing file]: [](assets/fig/doaj-spreadsheet.png)
episodes/08-database-design.md:57 [missing file]: [](assets/img/field-record-value.png)
episodes/08-database-design.md:100 [missing file]: [](assets/fig/normalisation.png)
instructors/instructor-notes.md:69 [link text too short]: [R](https://swcarpentry.github.io/sql-novice-survey/11-prog-R/index.html)
@zkamvar zkamvar added run pending Lessons that have not yet been tested locally status: in progress This label is for lessons that are currently being processed, but still have issues lesson A Carpentries Lesson To Transition and removed run pending Lessons that have not yet been tested locally labels Apr 10, 2023
@tobyhodges tobyhodges added the early transition Lesson maintainers have indicated that this lesson can transition early label Apr 13, 2023
@zkamvar zkamvar mentioned this issue Apr 14, 2023
Closed
zkamvar added a commit that referenced this issue Apr 17, 2023
@zkamvar
fix librarycarpentry asset figs
323c629 
These figures were mistakenly placed in the assets folder when the
lesson was being created and we have to manually move these, ignoring
the site assets

This will address #65 and #69
@jyssy
Copy link

jyssy commented Apr 19, 2023

@tobyhodges and @zkamvar , the LC-SQL beta lesson is looking good. I like the style changes very much.

@zkamvar zkamvar added 02 May and removed early transition Lesson maintainers have indicated that this lesson can transition early labels Apr 27, 2023
zkamvar added a commit that referenced this issue May 1, 2023
@zkamvar
finalise transformation for lc/lc-sql
c5290ec 
This will address #69
@zkamvar zkamvar added status: ready This label is for lessons that are ready for transition to the workbench and removed status: in progress This label is for lessons that are currently being processed, but still have issues labels May 1, 2023
@zkamvar
Copy link
Contributor Author

zkamvar commented May 2, 2023

This run was successful, but had issues as described in a359d3e#commitcomment-111506914

@zkamvar
Copy link
Contributor Author

zkamvar commented May 2, 2023

fixed in a359d3e

@zkamvar zkamvar closed this as completed May 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
02 May lesson A Carpentries Lesson To Transition status: ready This label is for lessons that are ready for transition to the workbench
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@zkamvar @tobyhodges @jyssy