Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

swcarpentry/make-novice #75

Closed
5 of 7 tasks
zkamvar opened this issue Apr 10, 2023 · 3 comments
Closed
5 of 7 tasks

swcarpentry/make-novice #75

zkamvar opened this issue Apr 10, 2023 · 3 comments
Labels
early transition Lesson maintainers have indicated that this lesson can transition early lesson A Carpentries Lesson To Transition status: in progress This label is for lessons that are currently being processed, but still have issues

Comments

@zkamvar
Copy link
Contributor

zkamvar commented Apr 10, 2023

tracking issue for https://github.com/swcarpentry/make-novice

  • fix filter for image
  • fix syntax error (intro.md:313 should be reference link)
  • fix reference definition lists
  • fix setup location
  • move code/ folder to files/code/
  • fix all episode links with code/ to be files/code/
  • update commands.mk at top of lesson so that targets point to episodes/files/code/ and episodes/fig/
episodes/01-intro.md:313 [missing file]: [well-documented](gnu-make-documentation)
episodes/02-makefiles.md:412 [uninformative link text]: [here](code/02-makefile/Makefile)
episodes/09-conclusion.md:70 [missing file]: [](fig/09-conclusion-challenge-1.png)
index.md:51 [missing file]: [setup](setup.md)
@zkamvar zkamvar added run pending Lessons that have not yet been tested locally status: in progress This label is for lessons that are currently being processed, but still have issues lesson A Carpentries Lesson To Transition and removed run pending Lessons that have not yet been tested locally labels Apr 10, 2023
@tobyhodges tobyhodges added the early transition Lesson maintainers have indicated that this lesson can transition early label Apr 14, 2023
zkamvar added a commit that referenced this issue Apr 17, 2023
 - #76: inflammation-XX.png
 - #75: 09-conclusion-challenge-1.png
 - #73 , #72: github-create-*-XX.png
 - #74: bitbucket-create-*-XX.png
@zkamvar
Copy link
Contributor Author

zkamvar commented Apr 21, 2023

A note for @gcapes: The folder structure will change which means that you may be a little disoriented when you try to maintain any of the auxilary files for the lesson (e.g. code, figures, data). I've done my best to fix internal links so that they work, but there may still be places that I missed.

The differences that you will see:

styles workbench
data/ episodes/data/
fig/ episodes/fig/
code/ episodes/files/code/

The reasoning behind this shift is the notion that the lesson centers around the episodes. Anything that are related to episodes can be categorized as data, figures or other files (e.g. code, but could also be handouts). Having these live inside the episodes folder means that we can avoid the paradigm of working in one folder and having to think about the final website structure.

This means that you might need to adjust how you create your figures and make sure the commands.mk file is accurate.

@zkamvar
Copy link
Contributor Author

zkamvar commented Apr 24, 2023

This is closed in e131513, but note the two issues remaining.

I could not fix the first issue because the reference link did not exist and I did not want to attempt to fix the second for fear that it would hinder repairing it if I did not correctly fix it.

Neither of these are urgent.

@zkamvar zkamvar closed this as completed Apr 24, 2023
@gcapes
Copy link

gcapes commented Apr 25, 2023

I've fixed the first - just need write access now :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
early transition Lesson maintainers have indicated that this lesson can transition early lesson A Carpentries Lesson To Transition status: in progress This label is for lessons that are currently being processed, but still have issues
Projects
None yet
Development

No branches or pull requests

3 participants