Add ci_bundle_pr_artifacts() #139
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Surprise surprise: it turns out the stackoverflow solution worked for what I needed at the time, but was certainly not a general solution. Here, I'm spelling out the explicit refspec string so that git will know which branch I'm fetching and _hopefully_ it will be more clear for future folk.
GHA will complain if the git user and email is not set... for good reason!
Working on other people's computers is hard, y'all
The CI deploy tests were giving strange results on different systems, so it was better to test the _concept_ of a branch _existing_ rather than the number of commits that were recorded. I believe the issue with the differing number of commits on the SITE branch is due to time splitting between minutes across tests (e.g. if the first deploy test happens in the same minute as the second deploy test, then there would be no change, but if it happened across times, then there would be three commits).
- Move PR message out of code and into template - expand on the prose in the PR message to be compliant with heading rules (don't start with level 3) - add clear description and link for people to report any issues - use triple-dot notation for linking to diffs so that people do not become discouraged from changes that happened upstream. - add timestamp to the file - update snapshot to compare the file without the timestamp
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
there are two things that happened in this PR:
ci_deploy()has been updated to be not so timestamp dependentHere's an example of the new PR message:
Thank you!
Thank you for your pull request 😃
🤖 This automated message can help you check the rendered files in your
submission for clarity. If you have any questions, please feel free to open an
issue in {sandpaper}.
If you have files that automatically render output (e.g. R Markdown), then you
should check for the following:
Rendered Changes
🔍 Inspect the changes: https://github.com/[user]/lesson/compare/landpaper-socal...landpaper-socal-PR-42
The following changes were observed in the rendered markdown documents:
What does this mean?
If you have source files that require output and figures to be generated (e.g.
R Markdown), then it is important to make sure the generated figures and output
are reproducible.
This output provides a way for you to inspect the output in a diff-friendly
manner so that it's easy to see the changes that occur due to new software
versions or randomisation.
⏱️ Updated at 2021-08-11 20:44:26 +0000