Add tests for git functions #137
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I now have a test fixture that sets up a local remote repository for me to "push" to and "pull" from so that I can test how the ci_ functions behave.
I've decided to move the test fixture generation inside the package because they are useful for live debugging.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request adds tests for git tests by incorporating a new test fixture that creates a remote repository to push and pull to within the system.
With this method, I can mock the behaviour of the
ci_*andworktree_*functions and check that their outputs continue to make sense.Tasks left to do:
- [ ] add option to handle output fromgit()operations (currently very noisy)- [ ] incorporate more unit tests forci_*operations- [ ] add test for archive generationedit: I don't want this PR to get too hairy, so I'm going to limit myself on tests for the moment.
Right now, the tests for ci_deploy() work and do bring up the test coverage to nearly 90% (which is a whole lot better than the ~80% we were hovering around). I won't be able to get to this until ten days from now, so I want to make sure I'm at a good stopping point.