Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix template page permissions issue #482

Merged
merged 4 commits into from
Jun 16, 2023
Merged

fix template page permissions issue #482

merged 4 commits into from
Jun 16, 2023

Conversation

zkamvar
Copy link
Contributor

@zkamvar zkamvar commented Jun 15, 2023

This ensures that templated files have the right permissions when appending common links to them so that 404 pages and other generated content can be built.

This will fix #479

This PR can be tested by installing it with the {pak} OR {remotes} package:

# via {pak}
# install.packages("pak")
pak::pkg_install("carpentries/sandpaper#482")

# via {remotes}
# install.packages("remotes")
remotes::install_github("carpentries/sandpaper#482")

Copy link
Contributor

@ocaisa ocaisa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Typo

R/render_html.R Outdated Show resolved Hide resolved
Co-authored-by: ocaisa <alan.ocais@cecam.org>
@zkamvar zkamvar merged commit cde8907 into main Jun 16, 2023
12 checks passed
@zkamvar zkamvar deleted the fix-permissions branch June 16, 2023 15:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Markdown file for 404 page created with read-only permissions
2 participants